Problem/Motivation

Drupal 9 is now using Symfony 4.4, this version changed the parameters order of the event dispatcher.

Steps to reproduce

Look for dispatch calls and check the deprecated parameters order.

Proposed resolution

Invert the parameters order of dispatch calls.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#2 symfony-4-4-event-dispatcher-parameter-order-change-3248186-2.patch1.46 KBtbsiqueira

Comments

tbsiqueira created an issue. See original summary.

tbsiqueira’s picture

tbsiqueira
He/him
commented
Status: Active » Needs review
StatusFileSize
new symfony-4-4-event-dispatcher-parameter-order-change-3248186-2.patch1.46 KB
navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community

  • Graber committed d83b999 on 4.0.x authored by tbsiqueira 
    Issue #3248186 by tbsiqueira: Symfony 4.4 event dispatcher parameter...
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Thank you!

tbsiqueira’s picture

tbsiqueira
He/him
commented

Hi @graber, thank you for using this patch. I want to add that this change is not compatible with Drupal 8 and I noticed that the version 4.x still supports Drupal 8.

Kind regards.

graber’s picture

graber commented
Status: Fixed » Needs work

Not good.

D8 is currently EOL but looking at https://www.drupal.org/project/usage/drupal..

I think we still need to support D8, check for Drupal version in code and act accordingly.

graber’s picture

graber commented

Quick hint making this super-easy: https://drupal.stackexchange.com/questions/260730/how-do-i-programmatica...

navneet0693’s picture

navneet0693 commented

@Graber: This patch could be utilized only when maintainers want to stop supporting Drupal 8 which can either be done in 5.0.x or in 4.1.x, whatever maintainers decide more.

This patch solves problems of deprecations warning for the people who are using Drupal 9 now and can add this a project in their projects.

  • Graber committed e7336a4 on 4.0.x 
    Issue #3248186: Keep supporting Drupal 8.