Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
4.1.x-dev
Component:
Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Feb 2022 at 21:59 UTC
Updated:
14 Mar 2022 at 13:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
heddnComment #3
heddn#2 didn't remove all the deprecations. This one should though. We need to handle using the deprecated event or the new event.
Comment #4
graber commentedAny reason for not using
Drupal\Component\EventDispatcher\EventinViewsBulkOperationsActionManageras done inViewsBulkOperationsEvent?Comment #5
heddnNo good reason.
Comment #6
victoria-marina commentedI'll review this.
Comment #7
victoria-marina commentedAfter the #3, I still found some deprecated
Event()warnings.So I made a patch to kill all the Symfony\Component\EventDispatcher\Event is deprecated warnings. Kindly review it.
Comment #8
victoria-marina commentedComment #9
graber commented@heddn, actually there is a reason.. Drupal 8 doesn't have that class. Probably I should drop D8 support from now as it's becoming troublesome.
Comment #10
graber commentedThis is actually bigger as there are many other deprecations in automated tests. I'll handle it.
Comment #11
graber commentedComment #12
graber commentedComment #13
graber commentedOne unused use statement left, no point re-adding a patch. I'll commit without it.
Comment #14
heddnLooks good to me. Just added a 9.4.x and php 8.1 test run and it came back green too.
Comment #16
graber commentedThanks!
Comment #18
graber commented