Problem/Motivation

As I was using the facets date range module, I tested my page with Axe Devtools (accessibility tool). It noticed that the label of the date element currently has no for attribute, which is a best practice of Web Content Accessibility Guidelines (WCAG).

Steps to reproduce

Proposed resolution

Add the label for attribute to the label of the date elements.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3273730-Add-for-attribute-to-label.patch925 bytesbertde.boer@hotmail.com

Issue fork facets_date_range-3273730

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bertdeboer created an issue. See original summary.

bertde.boer@hotmail.com’s picture

bertde.boer@hotmail.com CreditAttribution: bertde.boer@hotmail.com commented
FileSize
3273730-Add-for-attribute-to-label.patch925 bytes

I've added a patch which adds the for attribute to the label.

jlstrecker’s picture

jlstrecker
they/them
Primary language English
Location Athens, Ohio, USA
CreditAttribution: jlstrecker at Kosada commented
Status: Active » Needs review
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Smithsonian Institution commented
Version: 1.0.0-beta1 » 1.x-dev
Status: Needs review » Reviewed & tested by the community
Issue tags: +a11y

Confirmed this adds the for attributes as expected.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3273730-Add-for-attribute-to-label.patch, failed testing. View results

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Reviewed & tested by the community

Test failure is from 1.x HEAD.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented

Can anyone make a MR based on the patch?

jhedstrom opened merge request !8

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Smithsonian Institution commented

I added an MR with the changes from the patch.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.