Hi,
I use the Internationalisation module to translate menu items.
When using Menu Block, all menu items are shown on the right language section of my site.
The menu items that link to the page show up on all language sections.

So "Home" (EN section) and "Accueil" (FR section) both show up on each others section. Their languages are correctly configured.

CommentFileSizeAuthor
#9 menu_block-328238-9-i18nmenu.patch658 bytesJohnAlbin
#5 i18n_menu_block.patch923 bytesgorbeia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gorbeia’s picture

gorbeia CreditAttribution: gorbeia commented
Status: Active » Needs review

This happens when the content the menu entry is pointing to has no defined language. For example an external link or the frontpage. The attached patch works for me. Apply it against menu_block.module.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Component: Miscellaneous » Code
Status: Needs review » Active

No patch attached.

TD540’s picture

TD540 CreditAttribution: TD540 commented

I was gonna say the same thing.

gorbeia’s picture

gorbeia CreditAttribution: gorbeia commented
Status: Active » Needs review

Sorry, forgot to attach.

gorbeia’s picture

gorbeia CreditAttribution: gorbeia commented
FileSize
i18n_menu_block.patch923 bytes
TD540’s picture

TD540 CreditAttribution: TD540 commented

Patched perfectly. Thanx bro.

TD540’s picture

TD540 CreditAttribution: TD540 commented

Hmm,
Something must be wrong with the patch. There's a menu block that's not showing up. There were 2 menu blocks I created out of the Primary Links Menu, the first Primary links (levels 1-2), and second Primary links (expanded levels 3+).
The second one is not showing up.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

@tdskate: the block you set as “Primary links (expanded levels 3+)” will only show its contents when you are on a page that is a secondary level link of the Primary links menu. That is how the unpatched Menu block module works. So its not the patch that is causing this expected behavior.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: <front> path on menu item + Menu translation (i18n) » Add support for i18n menu translation
FileSize
menu_block-328238-9-i18nmenu.patch658 bytes

Thanks for the patch, gorbeia!

I re-rolled the patch and moved the call to i18nmenu_localize_tree($tree) down a few lines. We don't need to translate menu items that are about to be trimmed out of the tree.

Since I don't have i18nmenu, please review.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs review » Fixed

Fixed. http://drupal.org/cvs?commit=155890

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

najibx’s picture

najibx CreditAttribution: najibx commented
Status: Closed (fixed) » Active

when first creating "menu block", the language options is not available.
Only after block is created and then click configure, you'll see the option and it work accordingly.
It this how it should be?

dddave’s picture

dddave CreditAttribution: dddave commented
Status: Active » Closed (fixed)

yes