Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#23 context_d10comp_3286756.patch852 bytesHolka_a
#21 context_active_trail_updated_3286756.patch846 bytesHolka_a
#2 context_active_trail.2.x-dev.rector.patch846 bytesProject Update Bot

Issue fork context_active_trail-3286756

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Project Update Bot created an issue. See original summary.

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Status: Active » Needs review
FileSize
context_active_trail.2.x-dev.rector.patch846 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Issue summary: View changes

jonnyhocks made their first commit to this issue’s fork.

jonnyhocks opened merge request !2

jonnyhocks’s picture

jonnyhocks CreditAttribution: jonnyhocks at Welsh Government commented
Issue summary: View changes

I've created a fork and opened a merge request containing the patch generated in #2.

brunodbo’s picture

brunodbo
he/him
CreditAttribution: brunodbo at Textillia commented

The Context dependency in composer.json is for Context v4.1, which is incompatible with Drupal 10. We'll have to update that to Context v5, which is compatible with Drupal 10.

bletch made their first commit to this issue’s fork.

bletch’s picture

bletch CreditAttribution: bletch commented

I've updated to denote Context v5, would be good to get a Drupal 10 compliant release out. Please let me know if I can do anything else to help.

roaldnel’s picture

roaldnel CreditAttribution: roaldnel at Finalist commented

We would appreciate it if the merge request above by bletch could be approved and merged as soon as possible. The fix seems to be effective.

rahul17’s picture

rahul17 CreditAttribution: rahul17 at TATA Consultancy Services for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

MR !2 makes modules D10 compatible, tested with upgrade status and drupal check.

Moving this issue to RTBC.

nicole.harnish’s picture

nicole.harnish CreditAttribution: nicole.harnish commented

Context 4.1 is not D10 compatible so this will fail in that regard, as noted in #9

I am unable to install Context 5.0 with the patch updated to also use 6=5.0 in composer.json

Not sure if I am missing how exactly to get these working together

My apologies I have since learned that you cannot patch composer files so I too would love this to be merged as soon as possible.

Thank you!!

leraa’s picture

leraa CreditAttribution: leraa at ICF commented

I also tested and it worked as expected with no errors.

JayDarnell’s picture

JayDarnell
he/him
Primary language English
Location Guelph, Ontario
CreditAttribution: JayDarnell at CivicActions for LINCS commented

Could we please get the solution from bletch merged?

vflirt’s picture

vflirt CreditAttribution: vflirt commented

+1 for this being merged, the Context 5 rc1 for Drupal 10 has been released since 22 February 2023 so should be fine to go with it. Without this Drupal 10 upgrade is getting impossible.

thatguy’s picture

thatguy CreditAttribution: thatguy at Siili Solutions commented

+1 for getting this merged ASAP so D10 upgrade is possible

zanematthew’s picture

zanematthew CreditAttribution: zanematthew commented

+1 Agreed, can we please have this merged ASAP.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri as a volunteer commented

I agree with comment #7 that the Context dependency in composer.json is for Context v4.1, which is incompatible with Drupal 10. I cannot update the Context to v5 until the requirement from composer.json of 'Context active trail' is not changed to the proper version.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri as a volunteer commented

I also tested MR2 and it worked as expected with no errors. Please merge it as soon as possible. thank you!

gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt commented

+1 for this to be merged

Holka_a’s picture

Holka_a CreditAttribution: Holka_a as a volunteer and commented
FileSize
context_active_trail_updated_3286756.patch846 bytes

+2 for MR2 merge on priority, till then created patch for same.

gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt commented

One thing I'm not following is that this patch makes it D10 compatible but it has a dependency on "drupal/context": "^4.1" which is not D10 compatible and it does not have a patch to make it D10 compatible so how are people using this patch on D10? I mean it's compatible but can you actually be on D10 without updating context to ^5.0 as well?

NVM I understand now

Holka_a’s picture

Holka_a CreditAttribution: Holka_a as a volunteer and commented
FileSize
context_d10comp_3286756.patch852 bytes
daneduijnkerke’s picture

daneduijnkerke CreditAttribution: daneduijnkerke as a volunteer commented

How do I use this? Why is the merge taking so long?

I can't upgrade to D10 because of the composer.json context dependency. The patch applies after composer checks its dependencies so you can never patch composer files.

Any workaround please?

Deasly’s picture

Deasly CreditAttribution: Deasly commented

@danekin The only solution to this that I have been able to use to get past this is to:
1.) patch the current module with #23 using composer patches.
2.) Then copy the module to my custom modules folder and commit it to my repo.
3.) Then remove this module from composer.
4.) drush cr (cache rebuild)

When this patch merges finally some day i will re-add this module back to composer and delete the module folder out of my custom modules folder. Make sure you do a cache rebuild via drush every time you move the module so Drupal picks it up.

If someone else has a better solution let me know. Hope this helps someone as it was the only way for me to upgrade to drupal 10 without this merged in.

thatguy’s picture

thatguy CreditAttribution: thatguy at Siili Solutions commented

Guide here for using the patch with issue fork https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
CreditAttribution: 3li as a volunteer commented

For anyone struggling to apply patches or get this module working with context.
Inside composer.json can add the following to repositories

{
  "type": "package",
  "package": {
    "name": "drupal/context_active_trail",
    "type": "drupal-module",
    "version": "dev-8.x-2.x",
    "source": {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/context_active_trail-3286756.git",
      "reference": "2ad7b4324ddaa01db07bc187772c7aa917db5def"
    }
  }
}

Make sure this goes before:

{
  "type": "composer",
  "url": "https://packages.drupal.org/8"
}

Then to require the patched version you can use:
composer require drupal/context_active_trail:dev-8.x-2.x -W

Defcon0 made their first commit to this issue’s fork.

c_archer’s picture

c_archer CreditAttribution: c_archer as a volunteer and at Whisky Auctioneer commented

Is there a plan to get a release for the module?

gaurav_manerkar changed the visibility of the branch 3286756-automated-drupal-10 to hidden.

gaurav_manerkar changed the visibility of the branch 3286756-automated-drupal-10 to active.

gaurav_manerkar’s picture

gaurav_manerkar CreditAttribution: gaurav_manerkar at EPAM Systems commented

MR2 looks good, merged

gaurav_manerkar’s picture

gaurav_manerkar CreditAttribution: gaurav_manerkar at EPAM Systems commented
Status: Reviewed & tested by the community » Fixed
gaurav_manerkar’s picture

gaurav_manerkar CreditAttribution: gaurav_manerkar at EPAM Systems commented
Status: Fixed » Closed (fixed)