Closed (fixed)
Project:
Signup
Version:
5.x-2.6
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2008 at 01:08 UTC
Updated:
29 Nov 2008 at 01:41 UTC
Just wanted to get this issue started, since I know it was discussed in some other issues.
@dww - Could you let us know what issue's you'd require to be fixed for this release to occur? I know that the cck date support was one, that has been committed and there have been a few additional issues spawned from it, but I believe they have also been committed.
Thanks,
Shane
Comments
Comment #1
dwwI just finished committing all the issues I know of that I want to include in the release. In fact, I also just created the DRUPAL-5--2 branch and moved the 5.x-2.x-dev release to point to that. However, the last 24 hours has been quite a massive flurry of commits for this module, so I think the DRUPAL-5--2 branch needs some pretty thorough testing before I can create a 5.x-2.6 stable release. Any testing help would be most welcome. ;)
Thanks,
-Derek
Comment #2
dwwOk, I was wrong. ;) I'd like to get these two issues in before 5.x-2.6:
#328822: Remove global $form_values from hook_nodeapi() and otherwise clean up the logic
#328840: Rename the email tokens, especially %event and %eventurl
Both have patches that need review/testing (and I need sleep)... ;)
Comment #3
dwwTwo other issues now block this release:
#329668: Improve warning messages when CCK date fields are misconfigured
#329708: Reminder emails can be sent for nodes that already started
Comment #4
dwwAnd #330121: Shouldn't warn about CCK date configuration on event nodes
Comment #5
dwwlast of the known issues are committed. Please test the end of the DRUPAL-5--2 branch.
Comment #6
dwwActually, I found one other: #332968: Fix PHP warnings on signup settings page and rename _signup_admin_form to be less confusing -- needs review.
Comment #7
dwwThat one's committed, too. This is back to needs review...
Comment #8
dwwActually, at the risk of feature creep, I'd love to get #333257-11: Remove pile of broken "Cancel signup" buttons and use checkboxes for node/N/signups admin pages in before this release, too. I think it's a pretty nice UI improvement.
Comment #9
dwwCommitted that one, too. ;) This is back to needing testing (of the end of the DRUPAL-5--2 branch). I'd like to release in the next few days, if possible.
Comment #10
shanefjordan commentedSorry I pushed this topic and then kind of dropped off. I got pushed to another project and haven't had time to test this. But, I will definitely dedicate time this weekend to test this so you can get the release rolled out.
Thank you,
Shane
Comment #11
dwwdeviantintegral and I both tested DRUPAL-5--2 more this afternoon, so I tagged and created http://drupal.org/node/334578.