Automated Drupal 10 compatibility fixes

Last patch seems ok. After commit please put the issue back to active to keep getting updates from the update bot.

Re-rolled the patch to work with 8.5.2 until the 10 compatible release of the module is out.

Updated patch for 8.5.2.

Hello @maintainers:

The patch provided for D10 compatibility is working. When can we expect this update to be released ?

Thanks.

I had to do a small fix...

from:

$implements = \Drupal::moduleHandler()->getImplementations('sfweb2lead_webform_posted_data_alter');

to:

$implements = \Drupal::moduleHandler()->hasImplementations('sfweb2lead_webform_posted_data_alter');

#10 doesn't apply the patch correctly. Getting below error:

Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-05-15/sfweb2lead_webform-drupal...

I think, from the latest version of sfweb2lead_webform every thing is working fine. only we need to take care 2 things:

1. D10 compatibility
2. Replace Symfony\Component\EventDispatcher\Event with Symfony\Contracts\EventDispatcher\Event

Here is a new fresh patch for the same.

Updating the patch for D10 compatible

Had to update patch because of https://www.drupal.org/project/drupal/issues/3036459

Is there going to be a Drupal 10 version of this module?

I guess someone could offer to co-maintain. :-)

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Hello @maintainers:

Thanks for the patch, the patch provided for D10 compatibility is applied but while trying to upgrade Drupal core from 9.5.11 to 10.1.4 facing below problem. So is there any clue to move forward. Also is there any update to be released D10 compatibility?

  Problem 1
    - drupal/sfweb2lead_webform[dev-5.x, 5.2.0] require drupal/core ^8 || ^9 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (10.1.4).
    - drupal/sfweb2lead_webform 5.x-dev is an alias of drupal/sfweb2lead_webform dev-5.x and thus requires it to be installed too.
    - Root composer.json requires drupal/sfweb2lead_webform ^5.2 -> satisfiable by drupal/sfweb2lead_webform[5.2.0, 5.x-dev (alias of dev-5.x)].

Thanks.

For anyone struggling,
I know this is not the best practice but you can also do this.

{
    ...
    "require": {
        ...
        "drupal/sfweb2lead_webform": "dev-3289580-automated-drupal-10",
        ...
    },
    "repositories": {
        ...
        "sfweb2lead_webform": {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/sfweb2lead_webform-3289580.git"
        },
        ...
    },
    ...
}

Hello maintainers,

I have one question, since Webform 6.2.0-rc1 version supports Drupal 10 is Salesforce Web-to-Lead Webform Data Integration compatible with this version of Webform?

Hello maintainers,

Drupal 9 EOL is 1 November 2023, so is there any tentaive date to release D10 compatiable version of Web-to-Lead Webform Data Integration module? However above patches are not working for me to make it done D10 upgrade. Could you please have a look.

Thanks in Advance.

I have one question, since Webform 6.2.0-rc1 version supports Drupal 10 is Salesforce Web-to-Lead Webform Data Integration compatible with this version of Webform?

@milos33 I am on the lookout for any reports of incompatibility, but I have not seen any.

Drupal 9 EOL is 1 November 2023, so is there any tentaive date to release D10 compatiable version of Web-to-Lead Webform Data Integration module? However above patches are not working for me to make it done D10 upgrade. Could you please have a look.

@Parvateesam Marking this issue as "needs work" based on your testing. I am eager to get a D10-compatible patch (or even better, a merge request) committed and a release cut, but that depends on folks submitting and testing those changes.

The latest patch was no longer applying cleanly. I re-rolled that into an MR that is now building successfully on Tugboat so it is at least installing as expected. Please test MR5 and provide feedback or fixes there!

Hi @markdorison thanks for quick workaround, please find my comments below.

Step 1: I checked out MR5 in my local and tested, now it's D10 compatible w.r.t upgrade status module, screenshot attached for the same.
Step 2: After that I'm trying to upgrade drupal core from 9.5.11 to 10.1.5 but getting below error while running "composer update -W" please help to have a look into.

 composer update -W
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupal/sfweb2lead_webform[dev-5.x, 5.2.0] require drupal/core ^8 || ^9 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (10.1.5).
    - drupal/sfweb2lead_webform 5.x-dev is an alias of drupal/sfweb2lead_webform dev-5.x and thus requires it to be installed too.
    - Root composer.json requires drupal/sfweb2lead_webform ^5.2 -> satisfiable by drupal/sfweb2lead_webform[5.2.0, 5.x-dev (alias of dev-5.x)].

Thanks

@Parvateesam Thanks for testing! I don't believe running the update via Composer will work until this is committed and a release is tagged.

It will only work when using the D10 lenient stuff indeed.

This looks good to go. LGTM.