FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\node_title\node_title.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\node_title\README.txt
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
2 | WARNING | Line exceeds 80 characters; contains 89 characters
------------------------------------------------------------------------

README.md template

Follow the pattern in the README.md template.

CommentFileSizeAuthor
#2 line-exceed-character-3299947-2.patch320 bytesHarsh panchal

Issue fork node_title-3299947

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal CreditAttribution: Harsh panchal at Smashing Infolabs Pvt. Ltd. for Smashing Infolabs Pvt. Ltd. commented
Assigned: Harsh panchal » Unassigned
Category: Task » Bug report
Status: Active » Needs review
FileSize
line-exceed-character-3299947-2.patch320 bytes

I have fixed this and providing a patch.

AkashKumar07’s picture

AkashKumar07 CreditAttribution: AkashKumar07 at TO THE NEW commented
Title: Line exceeds 80 character » Update README.txt file
Category: Bug report » Task
Status: Needs review » Needs work

@Harsh panchal, thanks for providing the patch.
But, the README.txt file is not following the drupal template structure.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

sumit_thakur’s picture

sumit_thakur CreditAttribution: sumit_thakur at Dotsquares Ltd. commented
Assigned: Unassigned » sumit_thakur
Status: Needs work » Active

Need to update Readme.txt file to readme.md

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Title: Update README.txt file » Update README.txt file to README.md
Assigned: sumit_thakur » Unassigned
Issue summary: View changes
Status: Active » Needs work

Thanks, please follow the pattern under "README format" in the README.md template.

Please create an issue fork (click "Create issue fork") and commit to that, for easier preview and commenting.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
CreditAttribution: elber at CI&T commented
Assigned: Unassigned » elber

I will do that

elber opened merge request !7

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
CreditAttribution: elber at CI&T commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

I added a new Readme.md file following drupal standards. Please revise.

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Status: Needs review » Needs work

Thanks @elber, almost perfect! Please check my comments, and change to resolved when fixed.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
CreditAttribution: elber at CI&T commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
CreditAttribution: elber at CI&T commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I fix the sugested errors please revise.

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Status: Needs review » Needs work

Thanks, but there should to be a line before a list ... like this:

## Maintainers

Current maintainers:

- Deepak Bhati (heni_dee [...]

Or maybe, just like this?

## Maintainers

- Deepak Bhati (heni_dee [...]

Previously, the "Current maintainers:" line was included in the README.md template, but it doesn't really add any value, so I have removed it.

Also, please mark them as resolved in Gitlab.

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Status: Needs work » Needs review

I removed the "Current maintainers:" line, please review.

sumit_thakur’s picture

sumit_thakur CreditAttribution: sumit_thakur at Dotsquares Ltd. commented

sumit_thakur opened merge request !8

sumit_thakur’s picture

sumit_thakur CreditAttribution: sumit_thakur at Dotsquares Ltd. commented

Hi @ressa,
Thanks for your suggestion.
have review readme.txt file and coverted to readme.md.

we need to go with RTBC+

sumit_thakur’s picture

sumit_thakur CreditAttribution: sumit_thakur at Dotsquares Ltd. commented
Status: Needs review » Reviewed & tested by the community
ressa’s picture

ressa CreditAttribution: ressa at Ardea commented

Thanks @sumit_thakur.

Also, please close MR #8: https://git.drupalcode.org/project/node_title/-/merge_requests/8

heni_deepak closed merge request !8

heni_deepak made their first commit to this issue’s fork.

heni_deepak’s picture

heni_deepak CreditAttribution: heni_deepak at Dotsquares Ltd. commented
Status: Reviewed & tested by the community » Fixed

thanks @all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.