Closed (fixed)
Project:
Signup
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 Nov 2008 at 15:50 UTC
Updated:
26 Nov 2008 at 00:32 UTC
Jump to comment: Most recent file
_signup_admin_form() is really the form builder (actually, a helper function called by other form builders) for the signup settings on a given node. it's shared by the site-wide config page, where you can specify global defaults for all of those settings. furthermore, there's a PHP warning on the settings page since there's no node or node type at all, yet we're trying to call node_get_names().
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 332968_signup_node_settings_form.D5-2.3.patch | 6.81 KB | dww |
| #3 | 332968_signup_node_settings_form.HEAD_.3.patch | 6.87 KB | dww |
| #2 | 332968_signup_node_settings_form.D5-2.2.patch | 5.76 KB | dww |
| #2 | 332968_signup_node_settings_form.HEAD_.2.patch | 5.83 KB | dww |
| #1 | 332968_signup_node_settings_form.1.patch | 5.03 KB | dww |
Comments
Comment #1
dwwRenamed the function to signup_node_settings_form() and added a $node_type argument. This only needs to hit HEAD and DRUPAL-5--2 -- the PHP warning was added by #328647: Purge "event" from the UI (and code) unless we're talking about event.module, which was never backported to DRUPAL-5.
Comment #2
dwwBackported to DRUPAL-5--2, and fixed one other minor problem in both versions.
Comment #3
dwwBased on feedback from greggles in IRC, decided not to use drupal_strtolower() anywhere, and to always put the human-readable node type name in a placeholder for consistency.
Comment #4
dwwAfter further review from greggles in IRC, committed to HEAD and DRUPAL-5--2.