Problem/Motivation

As we're working in other EBT projects, we're putting a message when the module is uninstalled in order to inform the end-users that the EBT was uninstalled but the block type due to consistence reasons, since the user can have multiple blocks created using this block type.

Steps to reproduce

Proposed resolution

Created the missing ebt_stats.install
Implements the hook_uninstall
Set a message that inform that the ebt stats was uninstalled but the EBT block wasn't because of consistence reasons and if the users needs he/she can remove manually

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ebt_stats-3351685

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RenatoG created an issue. See original summary.

RenatoG opened merge request !6

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Active » Needs review

Implemented. MR is available at: https://git.drupalcode.org/project/ebt_stats/-/merge_requests/6

  • RenatoG authored d45cef96 on 1.4.x 
    Issue #3351685: Create the ebt_stats.install and implements...
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
CreditAttribution: levmyshkin commented

Hi Renato, thank you! Might be a Drupal message from messager will be more useful for developers:
https://www.drupal.org/node/2774931

Usually Recent Log messages report page is full of PHP notices and page not found errors. It will be hard to find the message after EBT module removing.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
CreditAttribution: levmyshkin commented
Status: Needs review » Fixed
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
CreditAttribution: levmyshkin commented
Status: Fixed » Closed (fixed)
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Hello Ivan!

Might be a Drupal message from messager will be more useful for developers:
https://www.drupal.org/node/2774931

Usually Recent Log messages report page is full of PHP notices and page not found errors. It will be hard to find the message after EBT module removing.

Agreed, really makes sense. I didn’t remember it. Good catch. Thanks

RenatoG opened merge request !7

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

I tested the suggestion from #5 and really worked well. Using Drupal message from messenger worked fine, and appeared in the log from drush command as well. So it'll works fine even on Drush command or in the UI trhough the CMS

MR created with that: https://git.drupalcode.org/project/ebt_stats/-/merge_requests/7