Problem/Motivation

A few changes are needed to make the module compatible with Drupal 10.

Steps to reproduce

Try to install the module with Drupal 10.

Proposed resolution

Fix the Drupal 10 compatibility issues.

Remaining tasks

- Create MR
- Review MR
- Merge MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork jsonapi_page_limit-3360180

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ricovandevin created an issue. See original summary.

ricovandevin opened merge request !5

ricovandevin’s picture

ricovandevin CreditAttribution: ricovandevin at Finlet for Carwebs commented
Issue summary: View changes
Status: Active » Needs review
Gold’s picture

Gold
they/them
Location 20 minutes in the future
CreditAttribution: Gold as a volunteer commented
Status: Needs review » Needs work

Looking good, just one small tweak from what I'm seeing.

Commented on the fork.

https://git.drupalcode.org/issue/jsonapi_page_limit-3360180/-/commit/2d3...

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti’s picture

bharath-kondeti CreditAttribution: bharath-kondeti as a volunteer and at Specbee commented
Status: Needs work » Needs review

Updated the PR addressing #4. Please review

dineshkumarbollu’s picture

dineshkumarbollu CreditAttribution: dineshkumarbollu at Valuebound for Valuebound commented

Hi

I reviewed the MR it as still one D10 compatible error

vendor/bin/drush upgrade_status:analyze jsonapi_page_limit
[notice] Processing /var/www/html/vb9/web/modules/contrib/jsonapi_page_limit-3360180.

================================================================================
JSON:API Page Limit, --
Scanned on Mon, 06/26/2023 - 14:01

FILE:
web/modules/contrib/jsonapi_page_limit-3360180/src/Controller/EntityResource.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 22 Class Drupal\jsonapi_page_limit\Controller\EntityResource
extends @internal class
Drupal\jsonapi\Controller\EntityResource.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T at Ministry of Justice (UK) commented

@dineshkumarbollu whilst use of @internal classes is flagged by upgrade status, they aren't necessarily a blocker to Drupal 10 compatibility.

See #3304053-7: Automated Drupal 10 compatibility fixes for similar discussion and linked to further details in Slack.

Unfortunately because JSON:API proudly does not expose an API (because "HTTP is the API"), this kind of mechanism is kind of inevitable.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T at Ministry of Justice (UK) commented
Status: Needs review » Needs work

  • Eli-T committed 669ed1aa on 8.x-1.x authored by ricovandevin 
    Issue #3360180 by ricovandevin, Eli-T, Gold: Drupal 10 compatibility
Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T at Ministry of Justice (UK) commented
Status: Needs work » Fixed
Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T at Ministry of Justice (UK) commented
Status: Fixed » Needs work

Let's drop support for Drupal 8 whilst we're here.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T at Ministry of Justice (UK) commented
Status: Needs work » Fixed

Actually that should be a separate issue now this one is included in a release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.