Problem/Motivation

The search icon is not completely visible, it is slightly cut off from the top and left side.. See the attached screenshots for reference.

Steps to reproduce

  1. Install the theme and enable it
  2. Go to the theme settings and choose Sidebar, Vertical Toolbar (Default)
  3. Go to admin/config/user-interface/admin-toolbar-search-settings
  4. Click ( Display the search input as a menu item.)
  5. Then you will get the issue.

search-icon

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 after.png9.05 KByashingole
#10 Before.png6.58 KByashingole
#6 3394541afterapplyMR.png69.8 KBnavya_kosaraju
#3 after-patch.png270.27 KBshweta__sharma
Screenshot at Oct 17 14-59-59.png362.96 KBshweta__sharma

Issue fork gin-3394541

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shweta__sharma created an issue. See original summary.

shweta__sharma opened merge request !319

shweta__sharma’s picture

shweta__sharma CreditAttribution: shweta__sharma at OpenSense Labs commented
Status: Active » Needs review
FileSize
after-patch.png270.27 KB

Pushed the code, kindly review it.
Thanks

shweta__sharma’s picture

shweta__sharma CreditAttribution: shweta__sharma at OpenSense Labs commented
Title: Search icon colour is different and it is not completely visible. » The search icon is not completely visible, it is slightly cut off from the top and left side.
Issue summary: View changes
navya_kosaraju’s picture

navya_kosaraju
Primary language Telugu
CreditAttribution: navya_kosaraju at Valuebound for Valuebound commented
Assigned: Unassigned » navya_kosaraju

I will review the MR

navya_kosaraju’s picture

navya_kosaraju
Primary language Telugu
CreditAttribution: navya_kosaraju at Valuebound for Valuebound commented
Assigned: navya_kosaraju » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
3394541afterapplyMR.png69.8 KB

I reviewed the MR and the icon looks fine, moving to RTBC

Rajeshreeputra made their first commit to this issue’s fork.

saschaeggi made their first commit to this issue’s fork.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab for Material, 1xINTERNET, Zoocha commented
Status: Reviewed & tested by the community » Needs review

I pushed some changes as this would affect the legacy toolbar variant when it shouldn't. Needs another review 👀

yashingole’s picture

yashingole CreditAttribution: yashingole at Specbee for Drupal India Association commented
FileSize
Before.png6.58 KB
after.png9.05 KB

Verified the MR !319, the search icon looks as expected. Added screenshots for reference, RTBC++

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab for OPTASY commented

Thanks y'all!

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab for OPTASY commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.