Problem/Motivation

As issues #3380799: Module does not support Bootstrap v3 syntax for vertical tabs and #3377313: Tab is not working in Bootstrap 5 make evident, there is a need for this module to "know" which version of the Bootstrap framework a site is using, so that it can modify markup to fit the expectations of the version.

This information cannot be derived from *how* the framework is integrated in Drupal, since this module's approach is to support any implementation in a custom or contrib theme. Therefore, sites need to be able to define *for* this module which version is being used.

Proposed resolution

Provide a site-wide configuration option in a settings form that allows the site to set whether this module should render content to be compliant with Bootstrap 3, Bootstrap 4, or Bootstrap 5.

Once this configuration option is in place, #3380799: Module does not support Bootstrap v3 syntax for vertical tabs and #3377313: Tab is not working in Bootstrap 5 can be completed, with conditional logic to adjust as necessary to the Bootstrap framework version.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mark_fullmer created an issue. See original summary.

mark_fullmer’s picture

Title: Configuration option to indicate which version of Bootstrap is being used » Configuration option to set which version of Bootstrap is being used
mmarler’s picture

Status: Active » Needs review

mmarler changed the visibility of the branch 2.x to hidden.

mmarler changed the visibility of the branch 2.x to active.

mark_fullmer’s picture

Status: Needs review » Needs work
mmarler’s picture

Status: Needs work » Needs review
mark_fullmer’s picture

Status: Needs review » Needs work
mmarler’s picture

Status: Needs work » Needs review
mark_fullmer’s picture

Status: Needs review » Reviewed & tested by the community

With the latest changes, this looks good to go! Nice work.

  • mmarler committed d240ad2e on 2.x
    Issue #3397732 by mmarler, mark_fullmer: Configuration option to set...
mmarler’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.