Problem/Motivation

The "Save" button and the "Hide Sidebar Panel" are not visible without scrolling down. However, when scrolling down the page, the left side content, which is page title,'s font size decreases, then it is visible.
I have attached a screenshot for better reference.

Steps to reproduce

  1. Install theme
  2. click on add content and make one node for article.

Proposed resolution

If you replace display: flex; with display: grid; for ".region-sticky__items__inner," the issue will be resolved.

Example

CommentFileSizeAuthor
#10 after-patch.png501.59 KBlokeshsahu
#10 before-patch.png399.03 KBlokeshsahu
#9 after-patch.png151.95 KBshweta__sharma
#7 3400772-7.patch292 byteskevinfunk
#6 sidebar-panel-button-hidden.png10.08 KBsnowmountain
Edit Article Marijuana_ The Secret To Enhanced Athletic Performance _ Contribution - Google Chrome 2023-11-10 15-28-17.mp431.86 MBNitin shrivastava
Screenshot 2023-11-10 151639.png31.91 KBNitin shrivastava

Issue fork gin-3400772

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nitin shrivastava created an issue. See original summary.

Nitin shrivastava opened merge request !334

Nitin shrivastava’s picture

Nitin shrivastava CreditAttribution: Nitin shrivastava at OpenSense Labs commented
Status: Needs work » Needs review
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs review » Postponed (maintainer needs more info)

In which scenario does this happen? Screen size, toolbar variant used, Drupal version?

Thanks

Nitin shrivastava’s picture

Nitin shrivastava CreditAttribution: Nitin shrivastava at OpenSense Labs commented

This is the default behavior when editing the node, which is visible before scrolling down, the issue to be observed.

snowmountain’s picture

snowmountain CreditAttribution: snowmountain as a volunteer commented
FileSize
sidebar-panel-button-hidden.png10.08 KB

I have noticed a similar situation. The sidebar panel button is hidden.

Drupal version 9.5.11
gin version 8.x-3.0-rc7

A workaround I used was to use the following CSS code:

.region-sticky__items__inner {
    width: 90%;
}

I uploaded a screnshot, https://www.drupal.org/files/issues/2023-11-25/sidebar-panel-button-hidd... .

sidebar panel button hidden

kevinfunk’s picture

kevinfunk
he/him
CreditAttribution: kevinfunk commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
3400772-7.patch292 bytes

It happens when there is an extra long page title.
I've tested with "Proin tempor aliquam orci, pretium egestas justo cursus id. Fusce et massa ac lorem sollicitudin sollicitudin. Duis vel."

d.steindl’s picture

d.steindl CreditAttribution: d.steindl as a volunteer commented

Hi, exactly. It occurred on forms with long entity titles.
Thanks for the patch #7. It resolves the issue in my projects.

shweta__sharma’s picture

shweta__sharma CreditAttribution: shweta__sharma at OpenSense Labs commented
FileSize
after-patch.png151.95 KB

Yes @kevinfunk you are correct It happens when there is a long page title. I tested the #7 patch on Drupal 11 and it resolved the issue.

image

lokeshsahu’s picture

lokeshsahu CreditAttribution: lokeshsahu at Material commented
FileSize
before-patch.png399.03 KB
after-patch.png501.59 KB

I have verified the issue with the help of #7 in Drupal 10 and the patch applied successfully without any error and fixed the issue. I have attached the screenshot for reference.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs review » Needs work

Somehow this MR got created from the wrong source branch (8.x-3.x) so the work needs to be transferred to the correct source branch (3400772-save-button-and) before we can move ahead with this 👀

djsagar made their first commit to this issue’s fork.

djsagar opened merge request !341

djsagar’s picture

djsagar CreditAttribution: djsagar at OpenSense Labs commented
Status: Needs work » Needs review
Issue tags: +Needs tests

Updated MR based on comment #11 and updated tag for test the MR.

Thanks!

kevinfunk’s picture

kevinfunk
he/him
CreditAttribution: kevinfunk commented
Status: Needs review » Needs work

@djsagar I believe my patch from #7 is a more elegant approach.

kevinfunk changed the visibility of the branch 8.x-3.x to hidden.

kevinfunk’s picture

kevinfunk
he/him
CreditAttribution: kevinfunk commented
Status: Needs work » Needs review
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs review » Needs work

@kevinfunk thank you 👏

I left some blocking comments in the MR itself, otherwise LGTM 👀

kevinfunk’s picture

kevinfunk
he/him
CreditAttribution: kevinfunk commented
Status: Needs work » Needs review

Thanks @saschaeggi.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Thanks @kevinfunk LGTM 👌, waiting for a participant in this thread to set it to RTBC so we can merge 👍

leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx at 1xINTERNET commented
Status: Needs review » Reviewed & tested by the community

I can confirm the MR fixed it for me.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Awesome let's get this merged then 👏

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Reviewed & tested by the community » Fixed

Thanks y'all for participating here 🙌

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.