Problem/Motivation

Using PHP 8.0 we can't change the Display Override option under the Query Settings modal.

Steps to reproduce

  1. Install D7 with PHP 8.0
  2. Create any view
  3. Click on the "Advanced" -> "Other" -> "Query settings" -> "Settings" link
  4. Change the Display Override option (first select element in the modal)
  5. Click on the "Apply (this display)" button

Actual result with an error:

TypeError: explode(): Argument #2 ($string) must be of type string, array given in explode() (line 310 of /[WEBSITE]/sites/all/modules/views/plugins/views_plugin_query_default.inc).

Proposed resolution

  1. Fix the issue.
  2. Add tests to the Views UI to prevent an error in the future.

Remaining tasks

No

User interface changes

No

API changes

No

Data model changes

No

CommentFileSizeAuthor
#6 interdiff_3_6.txt567 bytestibezh
#6 views-php8_type_error_plugin_query-3409931-6.patch2.61 KBtibezh
#3 views-php8_type_error_plugin_query-3409931-3.patch2.6 KBtibezh
#2 views-php8_type_error_plugin_query-TESTS_ONLY-3409931-2.patch1.52 KBtibezh

Issue fork views-3409931

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tibezh created an issue. See original summary.

tibezh’s picture

tibezh CreditAttribution: tibezh at Drupal Ukraine Community, jobiqo - job board technology commented
FileSize
views-php8_type_error_plugin_query-TESTS_ONLY-3409931-2.patch1.52 KB

Here is a patch with tests only, except failed status for PHP 8.

tibezh’s picture

tibezh CreditAttribution: tibezh at Drupal Ukraine Community, jobiqo - job board technology commented
FileSize
views-php8_type_error_plugin_query-3409931-3.patch2.6 KB

Here is a patch with tests + a fix.

tibezh’s picture

tibezh CreditAttribution: tibezh at Drupal Ukraine Community, jobiqo - job board technology commented
Assigned: tibezh » Unassigned
Status: Active » Needs review

A fail for PHP 8.2 & MySQL 8 tests is not related to the ticket (related ticket).
So we can review the patch.

tibezh opened merge request !13

tibezh’s picture

tibezh CreditAttribution: tibezh at Drupal Ukraine Community, jobiqo - job board technology commented
FileSize
views-php8_type_error_plugin_query-3409931-6.patch2.61 KB
interdiff_3_6.txt567 bytes

A little mistake in my previous patch, attached an actual one.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks good to me!

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Great work again @tibezh

tibezh’s picture

tibezh CreditAttribution: tibezh at Drupal Ukraine Community, jobiqo - job board technology commented
Parent issue: » #3347650: Plan for Views 7.x-3.30

I think it will be better to add into a new release

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Have confirmed the bug and have confirmed the fix. Thank you. And yes, this will be in the next release.

  • DamienMcKenna committed fb00aaf3 on 7.x-3.x authored by tibezh 
    Issue #3409931 by tibezh, klausi, joseph.olstad, DamienMcKenna: Views...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.