Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
A new property was added in #839444: Make serializer customizable for Cache\DatabaseBackend but doesn't use constructor property promotion.
Steps to reproduce
Proposed resolution
Merge request link
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3419356
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #6
taraskorpach CreditAttribution: taraskorpach as a volunteer and at Drupal Ukraine Community commentedI've created another merge request to avoid overwriting anyone's changes. @acbramley, could you take a look? Is it finally a "property promotion"?
Comment #7
andypostMR 6472 looks is what required but will have commit collision with #3419352: DatabaseBackend doesn't handle string typed $max_rows with $serializer
Comment #8
taraskorpach CreditAttribution: taraskorpach as a volunteer and at Drupal Ukraine Community commentedI've noticed this issue as well. Since I'm relatively new, could you explain how such conflicts are handled within the Drupal issue workflow? Will the conflicts be resolved in the issue that is merged first, or is there another way?
Comment #9
andypostAs the second one is RTBC already, let's keep this issue for rebase/re-roll
Comment #10
taraskorpach CreditAttribution: taraskorpach as a volunteer and at Drupal Ukraine Community commentedSounds great, thanks
Comment #11
smustgrave CreditAttribution: smustgrave at Mobomo commentedPostponing on #3419352: DatabaseBackend doesn't handle string typed $max_rows with $serializer soon as that lands this just needs to be rebased and put back in review
Comment #13
acbramley CreditAttribution: acbramley at PreviousNext for Service NSW commentedBlocker is in :)
Comment #14
taraskorpach CreditAttribution: taraskorpach as a volunteer and at Drupal Ukraine Community commentedLooks mergeable now.
Somewhat off-topic: PHPCS suggests that the code
$this->maxRows = $max_rows === NULL ? static::DEFAULT_MAX_ROWS : $max_rows;
could be simplified to$this->maxRows = $max_rows ?? static::DEFAULT_MAX_ROWS;
. Is it worth creating an issue for this?Comment #15
acbramley CreditAttribution: acbramley at PreviousNext for Service NSW commentedLooking good, thanks!
Re #14 - yes that can definitely be tidied up in another issue :)
Comment #17
longwaveCommitted 5ce8ede and pushed to 11.x. Thanks!