Problem/Motivation

If meta entity type is configured to not auto-create meta entities (so e.g. they are created only if needed), then the target entity might already have some cached data when the meta is created. In my use case, we render the canonical page of the target entity based on what we store in the meta entity (if it exist).

Proposed resolution

Invalidate cache tags of the target entity even if the meta entity is new.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 meta_entity-target_entity_cache_tags-3422612-7.diff4.94 KBhuzooka
#4 meta_entity-target_entity_cache_tags-3422612-4.diff4.46 KBhuzooka

Issue fork meta_entity-3422612

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Munyu for European Commission and European Union Institutions, Agencies and Bodies commented
Related issues: +#3081067: Provide option to not invalidate the target entity cache when the meta entity is updated, +#3169560: Host entity list cache tags are not invalidated when meta entity is updated or deleted

Adding related issues

huzooka opened merge request !9

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Munyu for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
meta_entity-target_entity_cache_tags-3422612-4.diff4.46 KB

Uploading patch.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Munyu for European Commission and European Union Institutions, Agencies and Bodies commented
Assigned: huzooka » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: meta_entity-target_entity_cache_tags-3422612-4.diff, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Munyu for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
meta_entity-target_entity_cache_tags-3422612-7.diff4.94 KB

Adding the same patch as in 4, but with suppressed deprecation warnings in MetaEntityAccessTest.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Munyu for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review

pfrenssen made their first commit to this issue’s fork.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Liip commented

Created followup to address the deprecation warning: #3438861: Deprecation warning in MetaEntityAccessTest.

  • pfrenssen committed ebe9b2de on 8.x-1.x authored by huzooka 
    Issue #3422612 by huzooka, pfrenssen: Target entity tags should be...
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Liip commented
Status: Needs review » Fixed

Thanks for the contribution, nice work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.