i have date/time 2.5, event 2-dev, and signup 2.7 installed

when I edit a node (even if I do not touch the date fields), signups close.

chris

Comments

dww’s picture

Category: bug » support
Status: Active » Postponed (maintainer needs more info)

Even if you don't touch the date, if you edit a node in the past, signups will close. It should tell you "'%node_type start time is already past the signup close-in-advance time, signups now closed." -- does it say that or something else?

You also said you have date 2.5 and event 2.x-dev, but you didn't say if signups were closing on all node types, just nodes with CCK date fields, just event nodes, etc. You didn't say how you have signup configured.

If you want help, you have to provide enough information for people to be able to help you...

Cheers,
-Derek

socialnicheguru’s picture

i only have singup enabled for event nodes. I will test it out on another type and get back to you.

it says: Signups closed for testtype
No it doesn't say it is past the start time or anything else. It just says it is closed (statement above)

The dates for the events are in the future. All I have to do is edit it (not touch anything), and hit enter. Then the signup closed messages comes up.

Thanks
C

(btw- this is a great module!)

brianbrarian’s picture

I'm encountering this same issue. Signup 2.7 and Event 2.x-dev.

I'm using signup only for event nodes. When I edit and save an existing event node (this particular event is 2 months in the future; signups are configured to close 48 hours in advance) which had signups enabled, then the "signups now closed" message is displayed:

"Event start time is already past the signup close-in-advance time, signups now closed."

When I re-edit the event, disable signup, and save - and then re-re-edit, enable signup, and save the event again, signups are working again. (Unless I edit the event again.)

I tested with a page node and did not have this problem; signups did not close after going back in to edit the page.

dww’s picture

Title: Signup closing when node is edited » Signup closing when event node is edited
Component: Code » Event integration
Assigned: Unassigned » dww
Category: support » bug
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new887 bytes
new908 bytes

Yup. I can reproduce this with the latest event.module from DRUPAL-5--2. I just discovered it was a logic bug in the event2 integration code in _signup_event_node_completed(). Attached patch seems to fix it. If anyone experiencing this problem could apply the patch and report back here that it works, that'd be a big help. Thanks.

brianbrarian’s picture

The d5 patch is working for me. Thanks!

dww’s picture

Status: Needs review » Fixed

Committed to HEAD, DRUPAL-6--1 and DRUPAL-5--1. Thanks for testing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Shai’s picture

I know this patch has already been committed, but just thought I'd add one more data point and a bunch of kudos:

1. Had the exact same problem
2. Applied the patch
3. Patch worked
4. Am very thankful to activelyOUT for reporting the bug and to dww for fixing it and maintaining the module. This is an awesome module.
5. I'm thankful for the issue queue
6. I can now brag yet one more time to my friends about another open source success story.

p.s. from the time the client reported the bug to the time I had it fixed (thanks to this thread) was 15 minutes.

Shai Gluskin
Content2zero

dww’s picture

@Shai: cool, thanks. :)

alex72rm’s picture

Version: 5.x-2.7 » 6.x-1.0-rc3
Component: Event integration » CCK Date integration
Priority: Normal » Critical
Status: Closed (fixed) » Active

Same problem arises with CCK Date integration.

The function _signup_date_node_completed() has an erroneous behavior while processing dates.

Maybe it's a problem with recent API Date update.

dww’s picture

Version: 6.x-1.0-rc3 » 6.x-1.x-dev
Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)

Does the problem go away if you use the latest 6.x-1.x-dev code (from the end of the DRUPAL-6--1 branch in CVS)? I'm guessing this bug is already fixed, and the code just isn't released yet.

alex72rm’s picture

I don't know. How can I download it? I haven't found any link to take that latest version.

Thanks a lot.

[edit]

I have found the cvs branch and downloaded the lastest date.inc version (1.19).
But the results are always the same: if I edit again a CCK content (with a CCK date configured as a signup), the date changes itself (in my case 4 months earlier - from 14. April 2009 to 14. December 2008, and then the signup becomes naturally closed). If I repeat again and again the simple body edit-operation, the CCK date changes itself again and again, this time one year earlier (from 14. December 2008 to 14. December 2007 and then 2006...).

dww’s picture

Never just use a single file from a different version. ;) Use the whole signup directory. Also, you can find all releases for any project by clicking on the "View all releases" link on that project node (with the nice RSS icon next to it -- should be easy to find). For example, for signup, it's here: http://drupal.org/node/29351/release

alex72rm’s picture

Hi again,

I have downloaded and installed the latest full -dev version (from "View all releases" link) (signup 6.x-2.x-dev, Last updated: March 19, 2009 - 01:19). But the behavior (specifically for cck date integration) is always the same, as written in #12.

alex72rm’s picture

Project: Signup » Date
Version: 6.x-1.x-dev » 6.x-2.x-dev
Component: CCK Date integration » Code
Assigned: dww » Unassigned
Status: Postponed (maintainer needs more info) » Active

Hi again,

I've found that the problem isn't regarding signup module, but date module.

It's best depicted here:

http://drupal.org/node/323018

dww’s picture

Project: Date » Signup
Version: 6.x-2.x-dev » 6.x-1.x-dev
Component: Code » Event integration
Assigned: Unassigned » dww
Status: Active » Closed (fixed)

Ok, then use #323018: Displayed Custom NLS date format resets to English date format in node/edit mode for this "new" bug in the date module, not this issue. Setting this back to the signup issue queue where it should rest in peace as it was at comment #9... (e.g. when people find this issue based on the CHANGELOG or a CVS commit message).