Table, Column and Alias names in SQL queries should be quoted.

Table, Column and Alias names in SQL queries should be quoted. I created a content type called match (for a game clan site) and the signup admin page threw up an SQL error because "match" is a reserved word in MySQL.

I fixed this for my specific case by updating _signup_date_admin_sql() in includes/date.inc with the following...

function _signup_date_admin_sql($content_type) {
  // Get the date field information for this content type.
  $field = signup_date_field($content_type);

  // In the case where the same CCK date field is being reused on multiple
  // content types, we'll potentially be JOINing on the same tables and
  // columns for different content types.  To defend against duplicate table
  // names or ambiguous columns in the query, use the content type to alias.
  $alias = $content_type;

  // See what fields to SELECT.
  $fields[] = $alias .'.'. $field['database']['columns']['value']['column'];
  if (isset($field['database']['columns']['timezone']['column'])) {
    $fields[] = $alias .'.'. $field['database']['columns']['timezone']['column'];
  }
  $table = '{'. $field['database']['table'] .'} `'. $alias . '`';
  return array(
    'fields' => $fields,
    'joins' => array("LEFT JOIN $table ON `$alias`.vid = n.vid"),
  );
}

Notice the additions of the backticks (`) around the alias.

However, having a quick glance over some of the code, I think this could be a widespread issue. I am not familiar with the internals if drupal enough to know if there is a function you can call to check names, or if similar updates are going to have to be made to all your database code.