Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It should probably be set after *all* after_build func were run.
Comment | File | Size | Author |
---|---|---|---|
#41 | 357021.patch | 1.37 KB | Kars-T |
#35 | 357021.patch | 1.37 KB | Kars-T |
#29 | form_after_build_node-357021.patch | 545 bytes | yched |
#26 | form.inc-D6_6.patch | 1.38 KB | Kars-T |
#24 | form.inc-D6_4.patch | 1.37 KB | Kars-T |
Comments
Comment #1
yched CreditAttribution: yched commentedAlso, it should use a drupal_function_exists($function). If the kitten that gets eaten is deemed small enough, I can roll that in the patch too.
Comment #3
Kars-T CreditAttribution: Kars-T commentedWanted to review this but as it did fail and seems a nice mini patch for code optimization I re-roll the patch for testing.
Comment #4
cburschkaThis looks good.
Comment #5
Dries CreditAttribution: Dries commentedGood catch. Committed to CVS HEAD. Thanks.
Comment #7
iva2k CreditAttribution: iva2k commentedSame problem exists in D6.
Comment #8
RoloDMonkey CreditAttribution: RoloDMonkey commentedPatch for D6.
Comment #10
Kars-T CreditAttribution: Kars-T commentedI say this source is RTBC! :)
Comment #11
Kars-T CreditAttribution: Kars-T commentedHmm the bot says otherwise. Sorry for the rtbc...
Comment #12
RoloDMonkey CreditAttribution: RoloDMonkey commentedTrying again.
Comment #13
Kars-T CreditAttribution: Kars-T commentedSetting it to "Needs review" or the bot won't check it!
Comment #14
RoloDMonkey CreditAttribution: RoloDMonkey commentedThe bot still hasn't checked the latest patch.
Do I need to resubmit it in order to get the bot to notice it?
Comment #15
Kars-T CreditAttribution: Kars-T commentedNormally I'd say no. But as I won't get any repsonse on IRC please try.
Comment #16
RoloDMonkey CreditAttribution: RoloDMonkey commentedComment #17
RoloDMonkey CreditAttribution: RoloDMonkey commentedThe status was immediately changed to 'Ignored'. Is that normal?
Comment #18
Kars-T CreditAttribution: Kars-T commented#8: form.inc_.patch queued for re-testing.
Comment #20
RoloDMonkey CreditAttribution: RoloDMonkey commentedComment #21
RoloDMonkey CreditAttribution: RoloDMonkey commentedI don't get it. How do I get this patch into the queue?
Comment #22
yched CreditAttribution: yched commentedDunno if that's related, but it looks like the patch is not generated from the root of the drupal dir.
Comment #23
RoloDMonkey CreditAttribution: RoloDMonkey commentedI don't think that is it. The status is immediately changed to 'Ignored'. The bot would have to look at it in order to tell if it is not generated from the root.
Also, I think it is generated from the root. There is this line in the patch:
RCS file: /cvs/drupal/drupal/includes/form.inc,v
Comment #24
Kars-T CreditAttribution: Kars-T commentedHere is my try. I made it with netbeans and full path. Maybe the bot will accept it...
Comment #26
Kars-T CreditAttribution: Kars-T commentedOkay this time a version with cvs diff -up. Lets see if I now have some luck today...
Comment #28
Kars-T CreditAttribution: Kars-T commentedSorry but this doesn't make sense. I am 99% sure this patch should work... No more patching tonight than. :(
Comment #29
yched CreditAttribution: yched commentedPuzzling indeed.
Let's try this one - without the trailing whitespace hunk.
Comment #31
Kars-T CreditAttribution: Kars-T commented#29: form_after_build_node-357021.patch queued for re-testing.
Comment #33
Kars-T CreditAttribution: Kars-T commented#29: form_after_build_node-357021.patch queued for re-testing.
Comment #35
Kars-T CreditAttribution: Kars-T commentedNext try
Comment #37
RoloDMonkey CreditAttribution: RoloDMonkey commentedIs the patch system broken? I just ran across another issue where a patch was Ignored for no obvious reason:
http://drupal.org/node/794586#comment-3342372
Comment #38
Kars-T CreditAttribution: Kars-T commented#35: 357021.patch queued for re-testing.
Comment #39
Kars-T CreditAttribution: Kars-T commentedI try a retest now. But probably HEAD has moved on. But still the patch error message shold be different. I did read there where problems because of -D6 suffix but even if I leave this out it won't work. I have no clue why this test fails all the time :(
Comment #41
Kars-T CreditAttribution: Kars-T commentedNext try :D
Comment #43
plopesc#3: form.inc-D7-v01.patch queued for re-testing.
Comment #44
Kars-T CreditAttribution: Kars-T commented#41: 357021.patch queued for re-testing.
Comment #46
rfay#41: 357021.patch queued for re-testing.
Comment #47
drupalexio CreditAttribution: drupalexio commentedComment #48
Cameron Tod CreditAttribution: Cameron Tod commentedIs this patch going to be added to Drupal 6 trunk? It's affecting some work I'm doing at the moment and I'd love to have it integrated into core.
Comment #49
rfayD6 commits are few and far between. To get this committed, you'll need to make it comprehensible to the maintainer (Gabor) and then perhaps directly bring it to his attention.
The first thing that would help would be to write a comprehensible issue summary. Just click the edit link on this node and follow the instructions. There's an issue summary template link there.
Comment #50
Cameron Tod CreditAttribution: Cameron Tod commentedI've since worked around this with a different approach, but if anyone wants me to summarise and chase it up I'm happy to do so.