Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

Also, it should use a drupal_function_exists($function). If the kitten that gets eaten is deemed small enough, I can roll that in the patch too.

Status: Needs review » Needs work

The last submitted patch failed testing.

Kars-T’s picture

Status: Needs work » Needs review
FileSize
697 bytes

Wanted to review this but as it did fail and seems a nice mini patch for code optimization I re-roll the patch for testing.

cburschka’s picture

Status: Needs review » Reviewed & tested by the community

This looks good.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Good catch. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

iva2k’s picture

Version: 7.x-dev » 6.x-dev
Status: Closed (fixed) » Active

Same problem exists in D6.

RoloDMonkey’s picture

Status: Active » Needs review
FileSize
1.3 KB

Patch for D6.

Status: Needs review » Needs work

The last submitted patch, form.inc_.patch, failed testing.

Kars-T’s picture

Status: Needs work » Reviewed & tested by the community

I say this source is RTBC! :)

Kars-T’s picture

Status: Reviewed & tested by the community » Needs work

Hmm the bot says otherwise. Sorry for the rtbc...

RoloDMonkey’s picture

FileSize
1.27 KB

Trying again.

Kars-T’s picture

Status: Needs work » Needs review

Setting it to "Needs review" or the bot won't check it!

RoloDMonkey’s picture

The bot still hasn't checked the latest patch.

Do I need to resubmit it in order to get the bot to notice it?

Kars-T’s picture

Normally I'd say no. But as I won't get any repsonse on IRC please try.

RoloDMonkey’s picture

FileSize
1.27 KB
RoloDMonkey’s picture

The status was immediately changed to 'Ignored'. Is that normal?

Kars-T’s picture

#8: form.inc_.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, form.inc_.patch, failed testing.

RoloDMonkey’s picture

Status: Needs work » Needs review
FileSize
1.27 KB
RoloDMonkey’s picture

I don't get it. How do I get this patch into the queue?

yched’s picture

Dunno if that's related, but it looks like the patch is not generated from the root of the drupal dir.

RoloDMonkey’s picture

I don't think that is it. The status is immediately changed to 'Ignored'. The bot would have to look at it in order to tell if it is not generated from the root.

Also, I think it is generated from the root. There is this line in the patch:

RCS file: /cvs/drupal/drupal/includes/form.inc,v

Kars-T’s picture

FileSize
1.37 KB

Here is my try. I made it with netbeans and full path. Maybe the bot will accept it...

Status: Needs review » Needs work

The last submitted patch, form.inc-D6_4.patch, failed testing.

Kars-T’s picture

Status: Needs work » Needs review
FileSize
1.38 KB

Okay this time a version with cvs diff -up. Lets see if I now have some luck today...

Status: Needs review » Needs work

The last submitted patch, form.inc-D6_6.patch, failed testing.

Kars-T’s picture

Sorry but this doesn't make sense. I am 99% sure this patch should work... No more patching tonight than. :(

yched’s picture

Status: Needs work » Needs review
FileSize
545 bytes

Puzzling indeed.
Let's try this one - without the trailing whitespace hunk.

Status: Needs review » Needs work

The last submitted patch, form_after_build_node-357021.patch, failed testing.

Kars-T’s picture

Status: Needs work » Needs review

#29: form_after_build_node-357021.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, form_after_build_node-357021.patch, failed testing.

Kars-T’s picture

Status: Needs work » Needs review

#29: form_after_build_node-357021.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, form_after_build_node-357021.patch, failed testing.

Kars-T’s picture

Status: Needs work » Needs review
FileSize
1.37 KB

Next try

Status: Needs review » Needs work

The last submitted patch, 357021.patch, failed testing.

RoloDMonkey’s picture

Is the patch system broken? I just ran across another issue where a patch was Ignored for no obvious reason:

http://drupal.org/node/794586#comment-3342372

Kars-T’s picture

Status: Needs work » Needs review

#35: 357021.patch queued for re-testing.

Kars-T’s picture

I try a retest now. But probably HEAD has moved on. But still the patch error message shold be different. I did read there where problems because of -D6 suffix but even if I leave this out it won't work. I have no clue why this test fails all the time :(

Status: Needs review » Needs work

The last submitted patch, 357021.patch, failed testing.

Kars-T’s picture

Status: Needs work » Needs review
FileSize
1.37 KB

Next try :D

Status: Needs review » Needs work

The last submitted patch, 357021.patch, failed testing.

plopesc’s picture

Status: Needs work » Needs review

#3: form.inc-D7-v01.patch queued for re-testing.

Kars-T’s picture

#41: 357021.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 357021.patch, failed testing.

rfay’s picture

Status: Needs work » Needs review

#41: 357021.patch queued for re-testing.

drupalexio’s picture

Status: Needs review » Reviewed & tested by the community
Cameron Tod’s picture

Is this patch going to be added to Drupal 6 trunk? It's affecting some work I'm doing at the moment and I'd love to have it integrated into core.

rfay’s picture

D6 commits are few and far between. To get this committed, you'll need to make it comprehensible to the maintainer (Gabor) and then perhaps directly bring it to his attention.

The first thing that would help would be to write a comprehensible issue summary. Just click the edit link on this node and follow the instructions. There's an issue summary template link there.

Cameron Tod’s picture

I've since worked around this with a different approach, but if anyone wants me to summarise and chase it up I'm happy to do so.

Status: Reviewed & tested by the community » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.