Hi,

I'm using l10n server for Brazilian Portuguese translation. Sometimes, I have to change a string that is translated correctly, but in the wrong case. For instance:

Og: Grupo: Número de Inscritos

I want it to read:

OG: Grupo: Número de inscritos

(think of a more extreme case: somebody mistakenly wrote something like "LOCAlization serVer")

The problem is when I try to save the corrected translation it says it's duplicated. But it's not really duplicated.

My request is to remove case-insensitiveness from duplicated translations checker.

CommentFileSizeAuthor
#15 duplicate_translations_verifier_should_be_case_sensitive-371056-15.patch933 bytesanemes
#12 duplicate_translations_verifier_should_be_case_sensitive-371056-12.patch584 bytesanemes
#10 Duplicate translations verifier should be case sensitive - 371056 - 9.patch584 bytesanemes
#9 Duplicate translations verifier should be case sensitive - 371056 - 9.patch584 bytesanemes
#5 case-fix.patch1.31 KBgábor hojtsy
#3 l10n_duplicate.patch1.19 KBmeba

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Good idea, agreed.

meba’s picture

meba commented

The search and code itself IS case-sensitive. It's made insensitive in MySQL. I need to investigate if the problem is in the table definition/db definition or it's just safe to change the query to "WHERE xyz = BINARY 'xyZ'"

meba’s picture

meba commented
Status: Active » Needs review
StatusFileSize
new l10n_duplicate.patch1.19 KB

OK, I have seen few BINARY occurences in current code. This patch should fix it.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Version: 6.x-1.0-alpha3 » 6.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

THX. That's works.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new case-fix.patch1.31 KB

Also added a line of comment to make it more clear, and committed this one.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Category: feature » bug

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

SebCorbin’s picture

SebCorbin commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Needs work

The corresponding query has not been translated correctly in 7.x-1.x http://drupalcode.org/project/l10n_server.git/blob/refs/heads/7.x-1.x:/l...

anemes’s picture

anemes commented
StatusFileSize
new Duplicate translations verifier should be case sensitive - 371056 - 9.patch584 bytes
anemes’s picture

anemes commented
Status: Needs work » Needs review
StatusFileSize
new Duplicate translations verifier should be case sensitive - 371056 - 9.patch584 bytes

Status: Needs review » Needs work

The last submitted patch, Duplicate translations verifier should be case sensitive - 371056 - 9.patch, failed testing.

anemes’s picture

anemes commented
StatusFileSize
new duplicate_translations_verifier_should_be_case_sensitive-371056-12.patch584 bytes
anemes’s picture

anemes commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, duplicate_translations_verifier_should_be_case_sensitive-371056-12.patch, failed testing.

anemes’s picture

anemes commented
Status: Needs work » Needs review
StatusFileSize
new duplicate_translations_verifier_should_be_case_sensitive-371056-15.patch933 bytes

We cannot use condition() method for the where clause because it would include the BINARY operator as part of the string, this is why we use the where() method.

SebCorbin’s picture

SebCorbin commented
Status: Needs review » Postponed

Could anyone give an exhaustive configuration description of collations, engines and such, because I cannot reproduce this behavior.