Extra space in Subject and Reply-to headers [#380334]

Both the subject and reply-to are getting extra white space. The subject after, and the reply-to it is before. I looked at the headers and it says my subject is this:

Subject: =?UTF-8?B?aGVsbG8gd29ybGQgaGVsbG8gd29ybGQK?=

Which I'm not sure is right.

Also the CSS combiner doesn't handle escape characters very well such as ' ' which it just turns into '???' also I'm using the simplenews statistics which adds an image url that has an ampersand (&) for multiple variables sent to the statistics php. The ampersand gets turned into an escape entity '&'. This actually happens twice, also in the click through link. Maybe there should be a rule that if ampersands are in an tag in the 'href' attribute don't convert them?

Comment	File	Size	Author
#6	mimemail_extraspace.png	7.59 KB	dboulet
#4	Snapshot 2009-03-02 22-12-20.jpg	34.47 KB	jerdavis

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jerdavis

Minneapolis, MN

CreditAttribution: jerdavis commented 22 February 2009 at 20:08

Can you send a sample message to mimemail at advantagelabs.com?

Comment #2

jerdavis

Minneapolis, MN

CreditAttribution: jerdavis commented 23 February 2009 at 16:15

Status:

Active

» Postponed (maintainer needs more info)

Comment #3

danielkorte CreditAttribution: danielkorte commented 24 February 2009 at 12:16

Just sent it..

Comment #4

jerdavis

Minneapolis, MN

CreditAttribution: jerdavis commented 3 March 2009 at 04:13

File	Size
Snapshot 2009-03-02 22-12-20.jpg	34.47 KB

This is what I received on this end - could you screenshot what you're expecting to see from your edit window?

Comment #5

Daniel Korte

he/him

English

Brooklyn, NY

CreditAttribution: Daniel Korte commented 26 March 2009 at 03:40

I had to sign up with a different name because my danielkorte account was blocked for some reason.

Anyway, I suppose the special characters might be a problem with the Simplenews module. But the headers are still receiving extra spacing in the above stated places.

Comment #6

dboulet CreditAttribution: dboulet commented 27 March 2009 at 21:15

File	Size
mimemail_extraspace.png	7.59 KB

Getting the same problem with the extra whitespace, here's a screen shot of what it looks like in Mail.

Comment #7

dboulet CreditAttribution: dboulet commented 6 May 2009 at 20:45

Status:

Postponed (maintainer needs more info)

» Active

Still getting the problem with the extra whitespace. I noticed that if I change line 224 of mimemail.module so that it does not pass the subject through mime_header_encode(), then everything is displayed as it should be. I still can't figure out why that is.

Comment #8

nsciacca

She/Her/Hers

English

Connecticut

CreditAttribution: nsciacca commented 13 May 2009 at 14:55

mimemail.module - 6.x-1.x-dev

line 119

$subject = mime_header_encode(drupal_html_to_text($subject));

If you remove the 'drupal_html_to_text' and leave just the mime_header_encode, everything works fine.

$subject = mime_header_encode($subject);

I'm not sure if this causing issues with HTML in the subject, but then again, why would there be HTML in the subject and reply-to? I think the mime_header_encode function would take care of the HTML anyways. I didn't make a patch, but if someone else could test this that would be great.

Comment #9

mhdg CreditAttribution: mhdg commented 13 May 2009 at 15:47

did the change as described in #8, and result is much better. In fact the header was encoded two time without this patch !

Comment #10

sgabe CreditAttribution: sgabe commented 1 April 2010 at 18:07

Title:	Subject and Reply-to messed up and CSS combiner not working on special entities	» Extra space in Subject and Reply-to headers
Status:	Active	» Closed (fixed)

Closing this issue, since the problem has been solved

$subject = mime_header_encode(trim(drupal_html_to_text($subject)));

long, long ago. Other things should be reported in separate issues.

Comment #11

ArtActivator.com CreditAttribution: ArtActivator.com commented 6 December 2013 at 15:39

Version:	6.x-1.x-dev	» 7.x-1.0-alpha2
Issue summary:	View changes
Status:	Closed (fixed)	» Active

Not resolved. What about Reply-To and From headers? it also have a space, if it will be long than x characters. all was fine while my from address contained only email. Now I added name, like name , and space appeared...