sort by term weight with "Summary, sorted ascending"

Subscribe

I edited Views to support "Summary, sorted as View".. I've got some warning on multiple view-sorting, but with only "Weight" it's working fine.
I'll post a patch, but I don't know if this will be merged with Views :/

post the patch, and then the patch will be reviewed,
its the normal way for every code of drupal

needs work, because there is missing code ;)

@dreine: I know, I know... I submitted other patches before as you can see from my profile :)

I said that because I feel that my patch is a "just works" hackish edit to Views :) I'll post it tomorrow :-)

Regards

Here is my patch (hum... my "try to be a-" patch)..
It's working, but is FAR away to be THE solution for this issue.

Some tips:

- this patch isn't no more related to "taxonomy-data" Component
- this patch appears under "Arguments -> Summary, Sort as View" (like "Summary, sort asc/desc")
- this patch incorporates also (partial) #424460: Configurable Argument Breadcrumb code

and last but not the least:

- this patch *really* needs work (and a better Views2 understanding than what I have)

Regards

I had the same problem (wanted to sort a taxonomy summary listing by weight, not by alphabetical).

The proposed solution here is interesting, because it would work for this use case as well as pretty much any others. I'm not adept enough at Views 2 to really suggest improvements, however.

I'm no coder, but am trying to create a Timeline view - nodes in right order on timeline - that can cope with WHEN vocab that includes terms like 1066, 1939, World War Two.

I figured that VIEWS2 sort by taxonomy weight (so WW2 is given a weight of 1939....) would do the trick, but it doesn't seem to work, and I don't think I've missed anything obvious (my whole site is now Views 2 driven so I've built a lot of them recently, though I still don't get arguments so can't play witgh that patch!).

UPDATE

IDIOT ME - weights run from -127 to 128 with higher/lower resetting accordingly. So year based ones fell over. Obviously an underlying binary thing going on. Works now.

Thanks, thePanz! This works for me.

Just starting to get the hang of views.
Assuming I have got the original question right, but you should be able to achieve a view of taxonomies sorted by their weight by creating a view of type 'taxonomy' rather than 'node' (it's the first set of options when you create a new view). Then set the filter to your vocab or tags, and sort criteria by taxonomy weight. Under the fields, you would set a 'taxonomy term' field to link to the taxonomy term page. Unless you are specifically needing the Summary argument action?

@areaten, yes this is really about sorting the summary provided by an argument.

This works for me.

Anything I can do to help get this committed?

I came across a similar sorting override problem trying to generate tag clouds with random content using view cloud module.

Stealing the implementation of a new argument summary sort option from thePanz above (and many thanks for that - it really helped sorting out how to solve my problem), and not calling the summary sort function, (and the immediately following code that disables the view sort) when this option is enabled, had exactly the desired effect.

More details here: http://drupal.org/node/505692#comment-2706360

Thanks again!

This definitive needs more work, because there is code commented out. I don't think this should be left in.

Sorry - I should have been clearer about what I was posting.

The code extract in the linked comment (http://drupal.org/node/505692#comment-2706360) has only additions to the Views 6.x-2.8 views_handler_argument.inc, and is not a modification of the patch posted here earlier by thePanz (which does contain commented out code).

The intention was to provide an option where the argument summary sort is devolved to the overall views sort, and I think that this is what the proposed changes do without interfering with other argument summary options.

I am rather new to this game, and also not a developer, so I apologise if this is not an appropriate way of publicising a solution to a particular problem I encountered. I cross-posted here as the thread seems to address a general case for which I had a particular "hack".

Any pointers on how I might do this better in future will be gratefully received!

The solution sounds good, but the patch doesn't apply to the latest version of views. I applied the patch manually, and it seems to work.

Marcus

subscribing!

subscribe

I haven't really gone into the depth of the patches or anything, just laying out how I think I might work this out, might try to submit a patch.

When selecting any of the following:
* Summary, sorted ascending
* Summary, sorted descending

I would display another two radios (dependent on the previous)

* Sort alphabetically
* Sort by weight

And change the logic to sort accordingly.

I also wonder if this can be made without patching views.

And I guess this applies to the latest version really

Actually took a deeper look at this it really proved to be more difficult than I thought.

I think the idea of the patch here is good, although I am not sure it will be flexible enough for any case. For instance I want to build the summary by weight regardless of the view sort criteria.

The way I see it has to be done, although I might not be able to do it at the moment, is to create a special argument handler for taxonomy name, add there additional options for sorting by weight and then build proper code (overriding the proper summary_ functions or creating a new default_summary alltogether).

I see if I can get this through, but not that familiar to every API calls on each of these. Basically, I wonder how to add programmatically the weight on the summary query.

I am marking this one as needs review only because I truly like some review on it, if at all possible by Views devs.

I kind of already know this is a work in progress patch but if this might get accepted I might spend a bit more time on it to follow it through into the code.

Of course, proper reviewing and suggestions on how to make it properly for acceptance is very much welcome.

EDIT: Remember to clear the views cache before trying out the patch

A few comments on this patch:

* UI side

- Once summary, sort ascending or summary sort descending is selected, another set of radios will appear allowing you to select between name and weight.

* Coding side

- It will only work for taxonomy term arguments (this is the main thing to fix probably for accepting it, and in which I have doubts in how to structure it properly without repeating too much code).
- It replaces the default views_handler_argument_string for a new argument handler (and argument handler file): views_handler_argument_term_name.inc
- If name was selected (default) in the UI, the normal name (string handling) will occur. If weight is selected, weight is added to the summary query and sorted by that term.
- If I used the Views API properly was only by intuition and luck :)

After the usual coding review of this particular patch, then it comes the task to propagate it to the other taxonomy handlers, which are quite a few, some with custom taxonomy handlers and others with default, such as tid which uses numeric argument handler, so I wonder how to make this work for all?

a.=

how do i insert the patch file in views?

@nallasivamkn: See the handbook page on Applying patches. Best wishes to you!

thank you so much....

subscribe

The basic idea here is good. However, it should also be set up against the basic term: tid argument, since I find that to be just as (if not more) common, and the weighting matters there as well.

Also, taxonomy weighting is by weight, then name so it needs two orderby calls, not just the one.

subscribe

The patch for views-7.x-3.x-dev

Possibly related https://drupal.org/node/1186724

I have this bug too.

In main page http://www.aprgr.ru I sort terms Гидроизоляция, Крепежи, Профлист, Сэндвич-панели, Теплоизоляция by weight. But it sorted alphabetically.

Russian alphabet:
АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ.

Drupal core 7.24
Views 7.x-3.7+20-dev (2013-Dec-24)

My bug has gone away after update Drupal to version 7.25.

After adding new taxonomy term and clear all caches bug appears again :(

I rerolled patch #30.

Patch #37 working for me. Please review.

37: views-sort_by_term_weight-417312.patch queued for re-testing.

Retesting patch after new commits in dev release.

Yes, tests passed! Needs review :)

Interested in this - hoping to see a solution soon...

37: views-sort_by_term_weight-417312.patch queued for re-testing.

Yeah, tests passed! Needs review still :)

After applying the patch I do not see any new options inside the contextual filter. Perhaps I'm looking in the wrong place.

paul53181: This option already exist without filter in Sorting Criteria. But without this patch sorting by weight is bugged (sometimes it sorts alphabetically instead of weight). After I apply this patch in latest dev version, I never seen this bug on view:

$view = new view();
$view->name = 'products_catalog';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'taxonomy_term_data';
$view->human_name = 'Каталог продуктов';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'Каталог продуктов';
$handler->display->display_options['use_more_always'] = FALSE;
$handler->display->display_options['use_more_text'] = 'ещё';
$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['cache']['type'] = 'time';
$handler->display->display_options['cache']['results_lifespan'] = '3600';
$handler->display->display_options['cache']['results_lifespan_custom'] = '0';
$handler->display->display_options['cache']['output_lifespan'] = '3600';
$handler->display->display_options['cache']['output_lifespan_custom'] = '0';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['exposed_form']['options']['submit_button'] = 'Применить';
$handler->display->display_options['exposed_form']['options']['reset_button_label'] = 'Сбросить';
$handler->display->display_options['exposed_form']['options']['exposed_sorts_label'] = 'Сортировать по';
$handler->display->display_options['exposed_form']['options']['sort_asc_label'] = 'По возрастанию';
$handler->display->display_options['exposed_form']['options']['sort_desc_label'] = 'По убыванию';
$handler->display->display_options['pager']['type'] = 'none';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['style_options']['row_class'] = 'product';
$handler->display->display_options['row_plugin'] = 'fields';
$handler->display->display_options['row_options']['default_field_elements'] = FALSE;
/* Поле: Термин таксономии: ID термина */
$handler->display->display_options['fields']['tid']['id'] = 'tid';
$handler->display->display_options['fields']['tid']['table'] = 'taxonomy_term_data';
$handler->display->display_options['fields']['tid']['field'] = 'tid';
$handler->display->display_options['fields']['tid']['label'] = '';
$handler->display->display_options['fields']['tid']['exclude'] = TRUE;
$handler->display->display_options['fields']['tid']['element_label_colon'] = FALSE;
/* Поле: Термин таксономии: URL каталога товаров */
$handler->display->display_options['fields']['field_link2']['id'] = 'field_link2';
$handler->display->display_options['fields']['field_link2']['table'] = 'field_data_field_link2';
$handler->display->display_options['fields']['field_link2']['field'] = 'field_link2';
$handler->display->display_options['fields']['field_link2']['exclude'] = TRUE;
$handler->display->display_options['fields']['field_link2']['type'] = 'text_plain';
/* Поле: Термин таксономии: Image of group */
$handler->display->display_options['fields']['field_image_of_group']['id'] = 'field_image_of_group';
$handler->display->display_options['fields']['field_image_of_group']['table'] = 'field_data_field_image_of_group';
$handler->display->display_options['fields']['field_image_of_group']['field'] = 'field_image_of_group';
$handler->display->display_options['fields']['field_image_of_group']['label'] = '';
$handler->display->display_options['fields']['field_image_of_group']['alter']['make_link'] = TRUE;
$handler->display->display_options['fields']['field_image_of_group']['alter']['path'] = '[field_link2]';
$handler->display->display_options['fields']['field_image_of_group']['alter']['absolute'] = TRUE;
$handler->display->display_options['fields']['field_image_of_group']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['field_image_of_group']['click_sort_column'] = 'fid';
$handler->display->display_options['fields']['field_image_of_group']['settings'] = array(
  'image_style' => 'taxonomy_product_group_image',
  'image_link' => '',
);
/* Поле: Термин таксономии: Имя */
$handler->display->display_options['fields']['name']['id'] = 'name';
$handler->display->display_options['fields']['name']['table'] = 'taxonomy_term_data';
$handler->display->display_options['fields']['name']['field'] = 'name';
$handler->display->display_options['fields']['name']['label'] = '';
$handler->display->display_options['fields']['name']['alter']['alter_text'] = TRUE;
$handler->display->display_options['fields']['name']['alter']['text'] = '<div>[name]</div>';
$handler->display->display_options['fields']['name']['alter']['make_link'] = TRUE;
$handler->display->display_options['fields']['name']['alter']['path'] = '[field_link2]';
$handler->display->display_options['fields']['name']['alter']['word_boundary'] = FALSE;
$handler->display->display_options['fields']['name']['alter']['ellipsis'] = FALSE;
$handler->display->display_options['fields']['name']['element_label_colon'] = FALSE;
/* Поле: Термин таксономии: Price of group */
$handler->display->display_options['fields']['field_price_of_group']['id'] = 'field_price_of_group';
$handler->display->display_options['fields']['field_price_of_group']['table'] = 'field_data_field_price_of_group';
$handler->display->display_options['fields']['field_price_of_group']['field'] = 'field_price_of_group';
$handler->display->display_options['fields']['field_price_of_group']['label'] = '';
$handler->display->display_options['fields']['field_price_of_group']['alter']['alter_text'] = TRUE;
$handler->display->display_options['fields']['field_price_of_group']['alter']['text'] = '<div class="price_of_group">
						<div class="left-price"></div>
						<div class="center-price">[field_price_of_group]</div>
						<div class="right-price"></div>
						<div class="clear"></div>
					</div>
<div class="shadow-pic"></div>';
$handler->display->display_options['fields']['field_price_of_group']['element_label_colon'] = FALSE;
/* Критерий сортировки: Словарь таксономии: Вес */
$handler->display->display_options['sorts']['weight']['id'] = 'weight';
$handler->display->display_options['sorts']['weight']['table'] = 'taxonomy_vocabulary';
$handler->display->display_options['sorts']['weight']['field'] = 'weight';
/* Критерий фильтра: Словарь таксономии: Машинное имя */
$handler->display->display_options['filters']['machine_name']['id'] = 'machine_name';
$handler->display->display_options['filters']['machine_name']['table'] = 'taxonomy_vocabulary';
$handler->display->display_options['filters']['machine_name']['field'] = 'machine_name';
$handler->display->display_options['filters']['machine_name']['value'] = array(
  'product_group' => 'product_group',
);

/* Display: Page */
$handler = $view->new_display('page', 'Page', 'page');
$handler->display->display_options['path'] = 'catalog-tovarov';
$handler->display->display_options['menu']['type'] = 'normal';
$handler->display->display_options['menu']['title'] = 'Каталог материалов';
$handler->display->display_options['menu']['weight'] = '0';
$handler->display->display_options['menu']['name'] = 'main-menu';
$handler->display->display_options['menu']['context'] = 0;
$handler->display->display_options['menu']['context_only_inline'] = 0;
$translatables['products_catalog'] = array(
  t('Master'),
  t('Каталог продуктов'),
  t('ещё'),
  t('Применить'),
  t('Сбросить'),
  t('Сортировать по'),
  t('По возрастанию'),
  t('По убыванию'),
  t('.'),
  t(','),
  t('URL каталога товаров'),
  t('<div>[name]</div>'),
  t('<div class="price_of_group">
						<div class="left-price"></div>
						<div class="center-price">[field_price_of_group]</div>
						<div class="right-price"></div>
						<div class="clear"></div>
					</div>
<div class="shadow-pic"></div>'),
  t('Page'),
);

and other views :)

I applied the patch to the current dev version of views (core 7.6) . When I sort my summary view by term weight I get no change. The sorting in the contextual filter overrides any sorting I have set in the sort criteria.

I not used sorting in contextual filter... Maybe you can off sorting in contextual filter?

37: views-sort_by_term_weight-417312.patch queued for re-testing.

paul53181: can you give me export the view with such trouble? Thanks.

$view = new view();
$view->name = 'services';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'node';
$view->human_name = 'Services';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'Services';
$handler->display->display_options['use_more_always'] = FALSE;
$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'some';
$handler->display->display_options['pager']['options']['items_per_page'] = '10';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'node';
/* Field: Content: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = '';
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = FALSE;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = FALSE;
/* Sort criterion: Content: Post date */
$handler->display->display_options['sorts']['created']['id'] = 'created';
$handler->display->display_options['sorts']['created']['table'] = 'node';
$handler->display->display_options['sorts']['created']['field'] = 'created';
$handler->display->display_options['sorts']['created']['order'] = 'DESC';
/* Filter criterion: Content: Published */
$handler->display->display_options['filters']['status']['id'] = 'status';
$handler->display->display_options['filters']['status']['table'] = 'node';
$handler->display->display_options['filters']['status']['field'] = 'status';
$handler->display->display_options['filters']['status']['value'] = 1;
$handler->display->display_options['filters']['status']['group'] = 1;
$handler->display->display_options['filters']['status']['expose']['operator'] = FALSE;
/* Filter criterion: Content: Type */
$handler->display->display_options['filters']['type']['id'] = 'type';
$handler->display->display_options['filters']['type']['table'] = 'node';
$handler->display->display_options['filters']['type']['field'] = 'type';
$handler->display->display_options['filters']['type']['value'] = array(
  'service' => 'service',
);

/* Display: Service - Selector */
$handler = $view->new_display('block', 'Service - Selector', 'block_2');
$handler->display->display_options['defaults']['style_plugin'] = FALSE;
$handler->display->display_options['style_plugin'] = 'list';
$handler->display->display_options['style_options']['row_class'] = 'tid-[tid]';
$handler->display->display_options['defaults']['style_options'] = FALSE;
$handler->display->display_options['defaults']['row_plugin'] = FALSE;
$handler->display->display_options['row_plugin'] = 'fields';
$handler->display->display_options['row_options']['default_field_elements'] = FALSE;
$handler->display->display_options['defaults']['row_options'] = FALSE;
$handler->display->display_options['defaults']['relationships'] = FALSE;
/* Relationship: Content: Service Category (field_service_categoy) */
$handler->display->display_options['relationships']['field_service_categoy_tid']['id'] = 'field_service_categoy_tid';
$handler->display->display_options['relationships']['field_service_categoy_tid']['table'] = 'field_data_field_service_categoy';
$handler->display->display_options['relationships']['field_service_categoy_tid']['field'] = 'field_service_categoy_tid';
$handler->display->display_options['defaults']['fields'] = FALSE;
/* Field: Content: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = '';
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = FALSE;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = FALSE;
/* Field: Taxonomy term: Term ID */
$handler->display->display_options['fields']['tid']['id'] = 'tid';
$handler->display->display_options['fields']['tid']['table'] = 'taxonomy_term_data';
$handler->display->display_options['fields']['tid']['field'] = 'tid';
$handler->display->display_options['fields']['tid']['relationship'] = 'field_service_categoy_tid';
$handler->display->display_options['fields']['tid']['label'] = '';
$handler->display->display_options['fields']['tid']['exclude'] = TRUE;
$handler->display->display_options['fields']['tid']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['tid']['separator'] = '';
$handler->display->display_options['defaults']['sorts'] = FALSE;
$handler->display->display_options['defaults']['arguments'] = FALSE;
/* Contextual filter: Taxonomy term: Name */
$handler->display->display_options['arguments']['name']['id'] = 'name';
$handler->display->display_options['arguments']['name']['table'] = 'taxonomy_term_data';
$handler->display->display_options['arguments']['name']['field'] = 'name';
$handler->display->display_options['arguments']['name']['relationship'] = 'field_service_categoy_tid';
$handler->display->display_options['arguments']['name']['default_action'] = 'summary';
$handler->display->display_options['arguments']['name']['default_argument_type'] = 'fixed';
$handler->display->display_options['arguments']['name']['summary']['number_of_records'] = '0';
$handler->display->display_options['arguments']['name']['summary']['format'] = 'default_summary';
$handler->display->display_options['arguments']['name']['summary_options']['count'] = FALSE;
$handler->display->display_options['arguments']['name']['summary_options']['items_per_page'] = '25';
$handler->display->display_options['arguments']['name']['limit'] = '0';
$handler->display->display_options['arguments']['name']['transform_dash'] = TRUE;

I have tried this patch, but didn't worked for me. Checked the view SQL query but didn't found any change any 'order by' part. Also Patch has only form API code and nothing to modify default query.

If anybody is further worked on it then please post the patch.

Patch #37 not work for me.

The 5 year old patch in #37 to views_handler_argument_term_node_tid.inc does not apply to the latest views 7.x-3.x-dev and if still relevant needs to be rerolled.

Checking patch modules/taxonomy/views_handler_argument_term_node_tid.inc...
error: while searching for:
    }
    return $titles;
  }
}

error: patch failed: modules/taxonomy/views_handler_argument_term_node_tid.inc:46
error: modules/taxonomy/views_handler_argument_term_node_tid.inc: patch does not apply

Patch rerolled.