hey there,
love the improvement in the private public default options.
would be really helpful if these could be different for each group created like the option to hide or make public the subscribe function.
example.. the intranet group defaults to private..
but the public yahoo group forum defaults to public.

thanks
ryan grace
thefractal.org

CommentFileSizeAuthor
#12 og_4.7.x-1.x-dev_private_group.patch4.13 KBmackh

Comments

jasonwhat’s picture

Priority: Critical » Normal

Which improvements are you speaking of? I was just thinking through this myself. I have some situations where I want group members to post into private forums, but the default is for "public" and the group to be checked and most don't bother to change it. Really, they shouldn't have the option to make their forum post public because it is a closed forum, but I have other content types that need to be in the group and public. I'm looking for a way to force users to post into the group only and the only option I can think of is to display my own submission form with hidden fields prefilled to force group only.


On a best practices note, please check the "priority" field of your bug reports. It is defaulting to "critical," so please change to "normal" before posting unless it really is critical. Thanks.

moshe weitzman’s picture

Assigned: Unassigned » moshe weitzman
Priority: Normal » Minor

yeah, this default should probably be a group by group decision. it is on the TODO list.

jo1ene’s picture

Component: Code » og.module

I would expect this to be the default behavior as well - in other words - it should not be a global option. The group manager should choose, when creating a group, the group privacy default - similar to choosing the submission requests policy: closed, open, etc.

What is the status on this TODO item?

moshe weitzman’s picture

The status is communicated here. It is an active feature request that i consider low priority. If someone provides a patch, I will review it.

jasonwhat’s picture

My suggestion is that the setting should be per node type rather than per group. That way admin could great different types of groups through CCK and supply default options. I think it might make sense to have all OG settings be based on a per node type setting.

jo1ene’s picture

I don't agree necessarily. The idea here is that some groups, particularly those who want moderated or closed subscriptions, may want their content closed as well. I don't believe we can expect end-users to check their checkboxes everytime they post, ehnce making it a group default.

rubenk’s picture

I too am seeking this
as per my other post
http://drupal.org/node/86297

I haven't even broken open OG code but maybe able to help someone who is a bit more familiar with OG. Alternatively, if someone can post a successful patch by Monday Oct 2 I'll chip in $13 by paypal.

rubenk’s picture

Priority: Minor » Normal

Can I bump this to normal now that some large patches have been completed Moshe?

beginner’s picture

Version: 4.7.x-1.x-dev » master

subscribing.

courtney’s picture

I also have the need for the public/ private settings to be on a per-group basis as veggieryan describes. Has there been a patch contributed? Comment #8 seems to indicate that there was?

Thanks!

mackh’s picture

I will work on a patch, have been addressing this need lately.
Will add another public private choice on group creation, which will determine whether or not the og_all record should be added to node_access for the group.
If the flag isn't present default behavior will be provided.

mackh’s picture

Version: master » 4.7.x-1.x-dev
Assigned: moshe weitzman » mackh
Status: Active » Needs work
StatusFileSize
new4.13 KB

Heres a patch against that stock 4.7.x-1.x-dev version of og.module. I know I should patch against HEAD, but I thought I would submit this as an interem step for people looking for this functionality in 4.7. There is still some paths to local files in the patch file, so its not really ready to go into the patch queue at this time. I am intending to resubmit a cleaner version of this against HEAD in the coming weeks.

Thanks to damien_vancouver for the code, and to http://postcarbon.org to sponsoring development efforts

What this patch does:
You will now see a new field when you create/edit a group to make the group private.

If the group is private when making a content post
(blog/forum/event/page/whatever) then you will not see the option to make it
public, it will just show Audience: and the group will be selected. If you
wish to cross post you can.

If the group is not private then you will be able to choose public.

For some reason I can't figure out the "Groups" header only shows up if you
get the option for public... if it's private the Audience: bit shows up but
not in a collapsible header called Groups... weird.

redraven’s picture

subscribing

inforeto’s picture

subscribing

drupalzack’s picture

The patch works great thanks so much!

One bug I noticed was if 'Make Group Private ' is checked, the group is marked private (I confirmed the functionality), but when you edit the group again, the check box is unchecked. Most likely a form update issue.

It gets a little confusing when 'list in groups directory' and 'Make group private' both are checked. The group doesn't appear on the groups directory for all except the group owner., yet the user would assume it will appear in the directory since 'list in groups dir' is checked.

An alternate suggestion would be: 'Make group private' should not control the group appearing/not appearing in the directory. That should be taken care of my 'list in groups dir' option.

ajwwong’s picture

subscribing *(with gratitude to you all)

karunadev’s picture

Hi I just posted this feature request to another OG issue "Support for private groups" http://drupal.org/node/83005#comment-231405. I think it belongs here.

Pardon me for cross-posting.

have created a private group in og-5.x-2.2 by using the following settings:

* Core OG settings:
   o Access control: Organic groups access control is currently enabled.
* Private Group settings:
   o Subscription requests: invite only - subscriptions must be created by an administrator.
   o [cleared] registration form
   o [cleared] list in groups directory

This group doesn't show up anywhere, unless you are a member, and posts to this group also, not even in the Recent Posts view (tracker); as long as the Group Audience Public box is cleared for each node posted to this group.

This last point is the thing, If the core "OG Node authoring form" settings could become configurable at the group level rather than globally then I could stop accidental public postings (forgetting to clear the Public list box).

You see, generally I want to most groups activity to be visible to all - an open community experience, with the exception of this one group which needs to be private.

Is it possible to have the global Node authoring setting "visibility of posts" to be changed from the global value "Visibility chosen by author/editor using a checkbox on the posting form. Checkbox defaults to Public." to a individual Group setting of "Visible only within the targeted groups" for a Private group.

This would then make the Audience bit disappear, or at very least I need the Group Audience Public box to be cleared by default.

L0rne’s picture

One bug I noticed was if 'Make Group Private ' is checked, the group is marked private (I confirmed the functionality), but when you edit the group again, the check box is unchecked. Most likely a form update issue.

I found a way to fix this. Find this line:

$form['og_group_private'] =  array('#type' => 'checkbox', '#title' => t('Make group private'),  '#default_value' => $node->og_group_private ? 1 : 0 , '#description' => t('Should this group be accessible by URL for non-subscribers?  Setting the group private will also cause new group content to be private by default.'));

and replace it with these two lines:

$og_group_private_value = og_node_load_private_group($node->nid);
$form['og_group_private'] =  array('#type' => 'checkbox', '#title' => t('Make group private'),  '#default_value' => $og_group_private_value, '#description' => t('Should this group be accessible by URL for non-subscribers?  Setting the group private will also cause new group content to be private by default.'));

By the way, thanks for this patch; it was exactly what I needed!

raintonr’s picture

Subscribing.

Why this is good for us is that we'd like to have numerous groups. Mostly though, hiding content isn't in the community spirit so want to force content 'public' in pretty much all cases.

However, let's say there is some over 18's rated content, users should post this into the 'Over 18s' group. Moderators should be able to push content in the queue in there if needed. Content in this group should be forced as only viewable to members of the group.

Thanks :)

Duncan Pierce’s picture

Subscribing after #172099 and #182603 marked duplicates.

moshe weitzman’s picture

Status: Needs work » Fixed

5.5 introduced private groups where the public checkbox defaults to private.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.