I noticed while working on #529250: Allow users to change their profile email address while signing up and #534948: signup_confirm_email breaks signup_status that if you edit an existing signup, and break something in the form and try to save your signup, the UI is a little sucky. When the form reloads with the validation errors, the JS still disables all the elements again and you have to click the "Edit" button again. The JS to convert the "Save" button into "Edit" and disable the form should only fire if there are no form errors. Pretty easy patch, stay tuned...

CommentFileSizeAuthor
#1 536094-1.signup_edit_validation_error_no_js.patch2.13 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 536094-1.signup_edit_validation_error_no_js.patch2.13 KB

To test, apply the patch, clear your JS cache (both on your site and in your browser). Login as a user with permissions to edit a signup, and make sure your signup form has a required field. Signup. When the page reloads, click the "Edit" button to allow yourself to edit the signup, clear out the required field, and hit "Save". When the validation errors appear, the form elements should all be enabled and the button should still say "Save".

mlsamuelson’s picture

mlsamuelson commented

Tested this patch (in conjunction with #534948: signup_confirm_email breaks signup_status) and it works as advertised - button still says save and the fields that previously were disabled before I enabled editing, are not disabled when I run through the test as described.

Only problem is the fields that were initially disabled (tested in FF, Safari, and Opera) - only the "attendance" drop down is ever getting disabled. I'm guessing this is related to #534948: signup_confirm_email breaks signup_status or maybe something I've done (I have custom submit and validation handlers via a form alter). I'll post to this to the other issue, since that's probably the place to look.

I'm tempted to mark this as reviewed and tested, but I guess I should hold off until the problem noted in the previous paragraph can be attributed elsewhere.

mlsamuelson’s picture

mlsamuelson commented
Status: Needs review » Reviewed & tested by the community

Patch works as expected. Please disregard the muddying of water in my previous comment.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Cool. Committed to HEAD and DRUPAL-6--1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.