Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Sep 2009 at 23:40 UTC
Updated:
29 Jul 2014 at 18:27 UTC
Jump to comment: Most recent
Comments
Comment #1
ChrisBryant commentedNice start Jacine! Subscribing.
Comment #2
pasqualle1.
2.
do we need the new $attributes parameter?
3.
there is no improvement here. I guess the
$link['attributes'] = array();line should be changed toor
4. in theme_menu_local_tasks() as I see the secondary local tasks will have a "tabs primary secondary" class after the patch..
Comment #3
scor commentedsubscribing. good initiative. We're already doing something similar in the RDF patches.
What are the plans to deal with the tpl files? Let themer alter the array of CSS classes before drupal_attributes?
Comment #5
jacineHmm... Was going to reroll this and keep going, but this seems like such a better approach: #572618: All theme functions should take a single argument to make preprocess sane and meaningful
Don't know what to do :(
Comment #6
TraumTaenzer commentedmenu.inc-attributes.patch queued for re-testing.
Comment #7
jacineToo late for this.
Comment #8
Anonymous (not verified) commentedI think that this is obsolete with the Twig work. Feel free to tell me I'm wrong.