Comment bulk update: warning if no comments selected. [#569196]

Situation

You have no comments on the site.
You visit admin/content/comment and hit Update to create any action, though the list is empty.

Following those steps, gets you the following error:

    *  Warning: array_diff(): Argument #1 is not an array in comment_admin_overview_validate() (line 113 of /home/manuel/htdocs/d7/modules/comment/comment.admin.inc).
    * Please select one or more comments to perform the update on.

Comment	File	Size	Author
#3	comment_warning.png	207.81 KB	aspilicious
#1	comment-bulk-operations.patch	934 bytes	mr.baileys

Comments

Comment #1

mr.baileys

Dutch

🇧🇪 (Ghent)

commented 13 February 2010 at 16:59

Title:

comment_admin_overview_validate breaks if no comments

» Comment bulk update: warning if no comments selected.

Status	File	Size
new	comment-bulk-operations.patch	934 bytes

Patch attached that verifies that $form_state['values']['comments'] is an array before performing array operations on it.

Also, the validation handler starts with:

$form_state['values']['comments'] = array_diff($form_state['values']['comments'], array(0));

Looking at comment_admin_overview, I don't see how $form_state['values']['comments'] can contain the value "0", so I suspect that this is a remnant from earlier times and have tentatively removed the array_diff portion since I think it is no longer needed...

Comment #2

mr.baileys

Dutch

🇧🇪 (Ghent)

commented 13 February 2010 at 16:59

Status:

Active

» Needs review

Comment #3

aspilicious commented 28 March 2010 at 19:21

Status	File	Size
new	comment_warning.png	207.81 KB

Still an issue and #1 still applies and works

"Looking at comment_admin_overview, I don't see how $form_state['values']['comments'] can contain the value "0", so I suspect that this is a remnant from earlier times and have tentatively removed the array_diff portion since I think it is no longer needed..."

Can someone gives this note a review and mark this rtbc (if the note is correct)