Closed (fixed)
Project:
Examples for Developers
Version:
7.x-1.x-dev
Component:
Other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Oct 2009 at 19:08 UTC
Updated:
12 May 2011 at 06:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
alexanderpas commentedfirst pass, only trigger_example.module needs a @file documentation block, all other issues are in this patch
Comment #2
alexanderpas commentedComment #3
jhodgdonPatch looks good to me. I went ahead and RTBC & then committed it to the D6 branch, all in one fell swoop. :)
We should probably do the same for Drupal 7 examples, eventually, once the Drupal 7 modules have been fixed up in general. They currently have much worse problems than coder violations!
Comment #4
rfayOK, this would be a great time for a D7 pass with coder if someone wants to try that.
Comment #5
rfayComment #6
ilo commentedI'd wait a little bit, there are several patches rolling in the queue and a single space character might require a reroll.. I'd tag issues with working patches first if you don't mind so we can decide a better moment to do so.
Comment #7
tr commentedAnd here's the patch ... let's see if the testbot likes it.
Comment #9
tr commented...and that's why we have the bot. I introduced a syntax error in one of those changes. Fixed in this new patch. Let's try again.
Comment #10
tr commentedRe: #6: Yes, there are a number of other patches in the queue that fix some of these Coder errors incidentally, and yes once any of these patches gets committed they might all need a re-roll. We have to start somewhere, however, and I'm willing to put in the work to re-roll any affected patch after this once gets committed. If I can get a RTBC on this I'll commit it then get to work on those other ones. They've *all* been sitting around in the queue too long.
Comment #11
rfayYep, let's get it done. Nice to have this good impetus. Thanks for your efforts tr!
Comment #12
tr commentedCommitted to 7.x-1.x and 8.x-1.x.
7.x-1.x commits:
commit 0ca81da02dabf1ede745b2cf8fca3e0c48f15fb2
commit 62bf19de515b9b0ff417612e5f2a23d5e0537340
8.x-1.x commits:
commit 0ca81da02dabf1ede745b2cf8fca3e0c48f15fb2
commit 7f6cefe8ed5584d5f04e29495bf8adc1704fc530