Run coder on existing modules

Comments

alexanderpas’s picture

StatusFileSize
new4.33 KB

first pass, only trigger_example.module needs a @file documentation block, all other issues are in this patch

alexanderpas’s picture

Status: Active » Needs review
jhodgdon’s picture

Version: 6.x-1.x-dev »
Status: Needs review » Active

Patch looks good to me. I went ahead and RTBC & then committed it to the D6 branch, all in one fell swoop. :)

We should probably do the same for Drupal 7 examples, eventually, once the Drupal 7 modules have been fixed up in general. They currently have much worse problems than coder violations!

rfay’s picture

Component: Code » Other

OK, this would be a great time for a D7 pass with coder if someone wants to try that.

rfay’s picture

Title: Run coder on existing modules » Run coder on D7 modules
ilo’s picture

I'd wait a little bit, there are several patches rolling in the queue and a single space character might require a reroll.. I'd tag issues with working patches first if you don't mind so we can decide a better moment to do so.

tr’s picture

Version: » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new44.78 KB

And here's the patch ... let's see if the testbot likes it.

Status: Needs review » Needs work

The last submitted patch, 595166-coder-changes.patch, failed testing.

tr’s picture

Status: Needs work » Needs review
StatusFileSize
new45.77 KB

...and that's why we have the bot. I introduced a syntax error in one of those changes. Fixed in this new patch. Let's try again.

tr’s picture

Re: #6: Yes, there are a number of other patches in the queue that fix some of these Coder errors incidentally, and yes once any of these patches gets committed they might all need a re-roll. We have to start somewhere, however, and I'm willing to put in the work to re-roll any affected patch after this once gets committed. If I can get a RTBC on this I'll commit it then get to work on those other ones. They've *all* been sitting around in the queue too long.

rfay’s picture

Status: Needs review » Reviewed & tested by the community

Yep, let's get it done. Nice to have this good impetus. Thanks for your efforts tr!

tr’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x and 8.x-1.x.

7.x-1.x commits:
commit 0ca81da02dabf1ede745b2cf8fca3e0c48f15fb2
commit 62bf19de515b9b0ff417612e5f2a23d5e0537340

8.x-1.x commits:
commit 0ca81da02dabf1ede745b2cf8fca3e0c48f15fb2
commit 7f6cefe8ed5584d5f04e29495bf8adc1704fc530

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.