Remove unimplemented theme('views_nodate') from the date handler [#608926]

Comment	File	Size	Author
#4	608926-theme-views-nodate.patch	862 bytes	longwave

Comment #1

dawehner

German

CreditAttribution: dawehner commented 10 May 2010 at 19:14

Priority:

Normal

» Minor

Thats minor

Log in or register to post comments

Comment #2

dawehner

German

CreditAttribution: dawehner commented 22 July 2010 at 19:52

Category:

bug

» task

This is a minor task, sorry but noone will ever need this.

Log in or register to post comments

Comment #3

dawehner

German

CreditAttribution: dawehner commented 25 October 2010 at 22:03

Status:

Active

» Postponed

This just is a problem if you are on a port of views to perhaps drupal8 :) Afaik this will not happen on a normal page run.

Log in or register to post comments

Comment #4

longwave

he/him

English

UK

CreditAttribution: longwave commented 12 November 2010 at 18:07

Title:	theme_views_nodata is missing	» Remove unimplemented theme('views_nodate') from the date handler
Status:	Postponed	» Needs review

File	Size
608926-theme-views-nodate.patch	862 bytes

I just noticed the call to theme('views_nodate') in the date handler and wondered why the theme function doesn't exist. I have a case where it would be invoked: if the date field is in a left joined table, the value could be null if there is no matching row.

Having said that, the empty text setting is obviously more flexible, so perhaps this should be removed? If you actually implement theme_views_nodate() then the empty text setting is always overridden. The attached patch removes the theme() call and applies to both 6.x-2.x and 6.x-3.x.