One problem on D6 was determining which file functions saved things to disk and which did things with filename strings.

It looks like D7 has made this more consistent and that the pattern is:
- file_create_FOO: does string things with names
- file_save_FOO: save data to disk

file_create_htaccess is an exception to this rule, however. For consistency it would be better renamed file_save_htaccess

CommentFileSizeAuthor
#5 613936-2.drupal.file_create_htaccess.patch1.71 KBjoachim
#1 613936.drupal.file_create_htaccess.patch1.97 KBjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 613936.drupal.file_create_htaccess.patch1.97 KB
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 7.x-dev » 8.x-dev

Too late for d7, because we are after API freeze.

pillarsdotnet’s picture

pillarsdotnet commented

#1: 613936.drupal.file_create_htaccess.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 613936.drupal.file_create_htaccess.patch, failed testing.

joachim’s picture

joachim commented
Status: Needs work » Needs review
StatusFileSize
new 613936-2.drupal.file_create_htaccess.patch1.71 KB

Rerolled.

pillarsdotnet’s picture

pillarsdotnet commented

#5: 613936-2.drupal.file_create_htaccess.patch queued for re-testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Seems reasonable considering file_create_filename() and file_create_url() are string operations while file_save_data() and file_save_upload() work with the file system itself. We'd need to make sure to document this in the 7/8 upgrade docs as well.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +API change, +Needs change record

Tagging as API change and pre-emptively tagging for docs.

catch’s picture

catch
he/him
Primary language English
commented

Not tagging this, but cross-linking #1221904: RFC: forwards compatibility in D7 / 'backports' defgroup to discuss possible ways to backport this.

pillarsdotnet’s picture

pillarsdotnet commented

#5: 613936-2.drupal.file_create_htaccess.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Category: bug » task
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs issue summary update

Tagging issues not yet using summary template.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Nice little clean-up. Consistency is good.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Fixed » Needs work

If this was an API change, then doesn't it need a change node? None is listed in the sidebar.

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical
Status: Needs work » Active

Bumping to critical and active for the change notification.

catch’s picture

catch
he/him
Primary language English
commented
Title: file_create_htaccess has an inconsistent name » API change notification for file_create_htaccess has an inconsistent name
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Novice

And since adding that summary is relatively easy, tagging as Novice.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: API change notification for file_create_htaccess has an inconsistent name » API change notification needed for: file_create_htaccess has an inconsistent name

I was confused by this issue title (it looked like it was saying the change notification had an inconsistent name!).

kathyh’s picture

kathyh commented

Change record created.

catch’s picture

catch
he/him
Primary language English
commented
Title: API change notification needed for: file_create_htaccess has an inconsistent name » file_create_htaccess has an inconsistent name
Status: Active » Fixed

Thanks! I think we can mark this fixed then.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -Needs issue summary update, -Novice, -Needs change record