Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
field.api.php is missing an ingroup hooks -- hooks such as http://api.drupal.org/api/function/hook_field_attach_form/7 are not showing here http://api.drupal.org/api/group/hooks/7
Comment | File | Size | Author |
---|---|---|---|
#22 | fieldapi-group-673224-22.patch | 1.76 KB | drupal_was_my_past |
#17 | fieldapi-group-673224-17.patch | 1.78 KB | drupal_was_my_past |
#9 | 673224_V2.patch | 1.69 KB | aspilicious |
#1 | 673224.patch | 1.69 KB | jhodgdon |
Comments
Comment #1
jhodgdonHere's a patch. That file was referencing a group that didn't even exist at the top, and it also had some non-standard doc lines.
Comment #2
jhodgdonComment #3
joachim CreditAttribution: joachim commentedBased on just a read, looks good :)
> - * Field Storage API
These bits are non-standard, but they do seem to be conveying information. Do we definitely want to lose that?
Comment #4
jhodgdonThe group start/stop lines are already there. The lines of ************* are redundant. I don't think there's a single other file in Drupal core that has them.
Comment #5
smyleeface CreditAttribution: smyleeface commented#1: 673224.patch queued for re-testing.
Comment #6
smyleeface CreditAttribution: smyleeface commentedSent for re-test because it didn't apply.
Comment #7
aspilicious CreditAttribution: aspilicious commentedstrange, it's green and I can't apply o_O
Comment #8
jhodgdonIt doesn't apply for me either. Needs reroll.
Comment #9
aspilicious CreditAttribution: aspilicious commentedquick reroll, sleepy so it's possible I made a mistake
Comment #10
jhodgdon#9: 673224_V2.patch queued for re-testing.
Comment #11
jhodgdon#9: 673224_V2.patch queued for re-testing.
Comment #12
jhodgdon#9: 673224_V2.patch queued for re-testing.
Comment #13
jhodgdon8.x now...
Comment #14
jhodgdon#9: 673224_V2.patch queued for re-testing.
Comment #16
jhodgdonGuess this needs a re-roll and then a review...
Comment #17
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedRe-roll patch from #9.
Comment #18
jhodgdonLet's get this in. Thanks rocket_nova!
Comment #19
Dries CreditAttribution: Dries commented#17: fieldapi-group-673224-17.patch queued for re-testing.
Comment #20
Dries CreditAttribution: Dries commentedAsking for a re-test as the patch does not appear to apply anymore.
Comment #21
catchApplied fine to me and looks like a good change.
While we're not backporting the big API docs clean-up patches, this looks like a straight bug to me, so moving back to 7.x for backport.
Comment #22
drupal_was_my_past CreditAttribution: drupal_was_my_past commented7.x ported patch attached for review.
Comment #23
jhodgdonThis looks fine.
Comment #24
webchickOh, awesome. This looks very helpful.
Committed and pushed to 7.x. Thanks!