I'm not sure why, but the mission block appears empty on my test upgrade of drupal.org, even if it is not empty neither in the database nor in the administrative UI:


CommentFileSizeAuthor
#11 garland-print-render-highlighted.patch925 bytesJeff Burnz
#1 garland_highlighted_region.patch916 bytesasimmonds
mission-block-empty-2.png74.42 KBdamien tournoud
mission-block-empty-1.png73.88 KBdamien tournoud

Comments

asimmonds’s picture

asimmonds commented
Title: Mission block appears empty after upgrade » Garland does not show any blocks in highlighted content region
Status: Active » Needs review
StatusFileSize
new garland_highlighted_region.patch916 bytes

Actually, no block can be shown in the highlighted region in Garland.

We missed a 'print'...

asimmonds’s picture

asimmonds commented
Component: block.module » Garland theme
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

works.
It's just a print => RTBC

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Needs work

Can we have a tiny test for that, pretty please?

aspilicious’s picture

aspilicious commented

Damnit lol thnx Damien for resolving the duplicate issue...
You gonna test if every render statement has a print before it?
Sounds like a weird test.

damien tournoud’s picture

damien tournoud commented

@aspilicious: a test for the site mission block would make sense and would test that at the same time.

aspilicious’s picture

aspilicious commented

True Damien, someone into this job?

Meriial’s picture

Meriial commented

The line 

          <?php if ($page['highlight']): ?><div id="highlight"><?php render($page['highlight']); ?></div><?php endif; ?>

is still present in Garland's page.tpl.php for Alpha6. (Render does not have a print statement.) Not sure that the earlier patch took.

Meriial’s picture

Meriial commented
Status: Needs work » Active
dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs work

This patch wasn't commited.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs work » Needs review
StatusFileSize
new garland-print-render-highlighted.patch925 bytes

Re-rolled.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

based on #4

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs work » Needs review

There is no site mission block anymore...

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Based on #6 and #13 I'm marking this rtbc

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.