Here's a screenshot showing the problem and a patch to fix.

CommentFileSizeAuthor
#6 update-version-table2.patch2.32 KBberdir
#4 update-version-table1.patch1.78 KBberdir
update-version-table.patch828 bytesjacine
update-version-table.jpg268.04 KBjacine

Comments

Status: Needs review » Needs work

The last submitted patch, update-version-table.patch, failed testing.

jacine’s picture

jacine
she/her
Location New York
commented
Component: update.module » markup
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The patch looks good for me, adds appropriate class but the test case fails irrespective of patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new update-version-table1.patch1.78 KB

This should pass the test. the classes were not always passed as an array.

Status: Needs review » Needs work

The last submitted patch, update-version-table1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new update-version-table2.patch2.32 KB

Wow, that's quite a mess. Looks like a random mix of string and array class definitions to me. Tried to unify but I'm just gessing if that's really the intended behaviour now... Someone needs to confirm that :) I clicked through the different versions produced by the test and it looked good to me.

The tests should really pass this time..

jacine’s picture

jacine
she/her
Location New York
commented

#6: update-version-table2.patch queued for re-testing.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Needs work

Hey, thanks for the patch @Berdir! It looks good to me, minus one little nit pick:

+++ modules/update/update.report.inc
@@ -137,8 +136,10 @@ function theme_update_report($variables) {
+          $security_class = $version_class;
+          $security_class[] = 'version-security';
           foreach ($project['security updates'] as $security_update) {
-            $row .= theme('update_version', array('version' => $security_update, 'tag' => t('Security update:'), 'class' => 'version-security' . $security_class));
+            $row .= theme('update_version', array('version' => $security_update, 'tag' => t('Security update:'), 'class' => $security_class));

Can we just call leave this as $version_class instead of adding $security_class? Unless I'm missing something, it's really still just another version class, right? ;)

Powered by Dreditor.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs work » Needs review

#6: update-version-table2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, update-version-table2.patch, failed testing.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs work » Closed (fixed)

Just checked and this is no longer a problem.