Just as mentioned, shouldn't it say something like "Primary Links Have Been Saved" ?

Figured I'd mention it, maybe it's just my theme, but it confuses me into saving twice.

CommentFileSizeAuthor
#4 menu.admin_.inc_.patch383 bytesjuampynr

Comments

cashwilliams’s picture

You are correct, there is no message presented that indicates the links were saved. The only visual feedback is the *s created when reordering the menu items will disappear once saved. This is common on most of the draggable tables like this in Drupal.

It should be easy to throw a dsm to the user indicating the save, but this would probably need to be something Drupal wide, rather then just the menu page. It looks like this is a similar issue that has been fixed in D7 #902738: No status message when reordering fields. and may fix this problem too.

juampynr’s picture

Category: bug » feature
Status: Active » Needs review
StatusFileSize
new383 bytes

Here is a patch for menu module. It adds an alert stating the action once the menu configuration is saved.

juampynr’s picture

And here is a snippet of code which does the job from a custom module (change 'mymodule' by any custom module name where this fits):

/**
 * Implementation of hook_form_alter()
 */
function mymodule_form_alter(&$form, $form_state, $form_id) {
  switch ($form_id) {
    case 'menu_overview_form':
      $form['#submit'][] = 'mymodule_add_post_save_alert_form_submit';
  }
}

/**
 * Submit handler that adds an alert after saving menu configuration
 */
function mymodule_add_post_save_alert_form_submit($form, &$form_state) {
  drupal_set_message(t('The menu configuration was saved.'));
}

Status: Needs review » Needs work

The last submitted patch, menu.admin_.inc_.patch, failed testing.

juampynr’s picture

I do not know why did the patch failed testing.

Changing status to "needs review".

juampynr’s picture

Status: Needs work » Needs review

Doh!

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.