Closed (fixed)
Project:
Examples for Developers
Version:
6.x-1.x-dev
Component:
Token Example
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
24 Feb 2010 at 22:58 UTC
Updated:
29 Oct 2010 at 21:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
dave reidSee also #734618: Move the tokenSTARTER to the Examples project
Comment #2
dave reidInitial token example. Still need to add token_example.tokens.inc.
Comment #3
dave reidOoh, I had a terrific idea on how to really demonstrate example 'tokens' by having this add a token type of 'text format' since it can also then demonstrate token chaining! Will post final version tonight!
Comment #4
dave reidOk happy to announce this is ready for final review. I'll also upload this to www.davereid.net/d7/examples/token so it can be previewed live.
Comment #5
dave reidCommitted to CVS! Working on a D6 example now.
http://drupal.org/cvs?commit=342326
Comment #6
rfayComment #7
janar commented#2: 724886-token-example-D7.patch queued for re-testing.
Comment #8
rfayThere is not yet a patch for D6.
Comment #9
slashrsm commentedI did some work on porting Token example to D6. Basic functionality is completed with D7 token example as a reference. There are no tests yet. Will wirte them, but I would like to get some feedback about current work first.
Comment #10
slashrsm commentedComment #11
ilo commentedThanks so much for the submission, slashrsm.
Examples are supposed to have good descriptions for every function/aspect/topic; indications about what is required, and what is optional, why/what could be, can be, must be, and should be, and some kind of script about what is the code doing (I already did that bad the first times I submitted examples). The backport to D6 needs comments, and the code needs explanation. Some cleanup is also required, i.e. the .info file has files[] directives that are only used in D7.
Marking as NW. slashrsm, currently the issue is assigned to Dave, if you are going to make that port, please, let us know to don't do the same work twice.
Thanks again!
Comment #12
slashrsm commentedI understand. Since I am currently at the beggining with my code contributions to Drupal, I asked for feedback. Thanks for it.
I submited this patch since I saw that there was no activity for some time at this issue. I'd love to finish this if it is fine with Dave and the others, or I can also leave it to somebody else.
Comment #13
ilo commentedSo, slashrsm, keep alive the issue, as long as Dave has raise a hand yet. Rfay is a little bit busy this week, and probably will be able to catch the issue in a few days, in the meantime you can do the cleanup, (pass coder module) and start digging about how to write a testcase for it.
Thanks for your help and contribution!
Comment #14
dave reidGah, I keep forgetting to make a patch for the module I have in D6, which is already completed and passes tests.
Comment #15
dave reidComment #16
slashrsm commentedLooks fine to me.
Comment #17
ilo commentedslashrsm, try to find the differences between your patch and the one submitted by Dave, and then grab another issue :) any help is appreciated, and newcomers are very very welcome. (If you are going to work on something it is a good idea to mention first in the issue queue).
Thanks again, and sorry for this confusion :) lets go with Dave's patch this time.
Comment #18
rfayCommitted to DRUPAL-6-1: http://drupal.org/cvs?commit=436172
Thanks, all.
Thanks so much for your patience with this, slashrsm. We welcome your participation.
Comment #19
slashrsm commentedNo problem. Will do that. I learned a lot through work on this patch, so it was defenetley not a waste of time. I will let you know before I start to code next time.