When a files directory is created, a message is always shown - which looks really untidy for end-users on 'real' sites.

So I've surrounded the line that sets the 'The directory ... has been created' with a variable_get, so this behaviour can be turned off if required. See the patch.

The variable to set to TRUE is 'file_show_directory_question_message'. Otherwise the default behaviour stays the same.

Comments

steven jones’s picture

subscribe.

reubenavery’s picture

subscribe.

reubenavery’s picture

I'd suggest that this be handled by user_access('administer content') or something similar rather than variable_get().. just a thought.

steven jones’s picture

Category: bug » feature

@reubidium Sure, but then you've changed the default behaviour of Drupal 6, which we'd all like to avoid. Sure some patches have been exceptions to this, but they have been bugs, this is more of 'feature'.

The variable_get allows site owners to turn off the message if they don't want it. Guess we could always OR the variable_get and user_access together?

benone’s picture

+1

Status: Needs review » Needs work

The last submitted patch, control_file_directory_msg.patch, failed testing.

steven jones’s picture

Status: Needs work » Needs review
StatusFileSize
new967 bytes

Re-rolled patch, though I can't see a difference.

Status: Needs review » Needs work

The last submitted patch, control_file_directory_msg_0.patch, failed testing.

steven jones’s picture

Status: Needs work » Needs review
StatusFileSize
new1.16 KB

Let's try again... this is patch from comment 7, re-rolled for git.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.