Various order pane functions need to pass order in uc_price context['subject'] variable [#727404]

Hi
The order pane uc_order_pane_payment in uc_payment does not pass the order in the context['subject'] variable to uc_price. For multicurrency support it needs to.
The uc_paypal call to in uc_payment_enter does not pass the currency of the transaction. For multicurrency support it needs to.
The uc_order subtotal/line items pane (uc_order_admin) does not pass the order in the context['subject'] variable to uc_price. For multicurrency support it needs to.
The attached patch handles these issues.
With this patched I have a working uc_multicurrency for D6/UC2/uc_paypal with payment in the users currency.
Thanks
Congrats on the D7CX pledge and good luck!
Lee Rowlands

Comment	File	Size	Author
	ubercart_uc_price_changes.patch	2.93 KB	larowlan

Comments

Comment #1

kingandy

he/him

commented 30 March 2010 at 11:26

+1 for this, though I think I'd go a stage further and do a full uc_order_load for each order on the uc_order_admin page (there may be important order details in there, like custom currency fields, that don't get fetched in the table query).

Comment #2

longwave

he/him

English

commented 18 March 2011 at 16:07

The first part of this patch has been committed. The second PayPal specific part I would like to make more generic if possible, and will be working on this in #1097668: Multicurrency support. The third part works for the order admin page, but the same problem occurs on the user order history pages; again the linked issue deals with this correctly.