As we fixed the fieldset issues for seven we can move on with the next one: Garland in IE8.

This issue is currently fixed for IE6/IE7 using hacks, but we don't have such a (valid) selector "hack" for IE8. Maybe we should instead those hacks set the background on the fieldset-wrapper div (introduced since #676800: Fieldsets break design badly)

CommentFileSizeAuthor
#2 garland.patch4.49 KBszantog
ie8-garland.png16.53 KBcasey

Comments

Jeff Burnz’s picture

Jeff Burnz commented

sub

szantog’s picture

szantog commented
Status: Active » Needs review
StatusFileSize
new garland.patch4.49 KB

The problem is the next: There are the solution in ie-fix.css. But this is rendered only in ie6.
In template.php there are:
drupal_add_css(path_to_theme() . '/fix-ie.css', array('weight' => CSS_THEME, 'browsers' => array('IE' => 'lt IE 7', '!IE' => FALSE)));

Imho it needs two separate ie files (I'm sure, we will get other error). First, I used the names fix-ie and fix-ie6, but i saw the other core themes, there are ie.css and ie6.css. I think, we need to apply this names consequently, therefore in this patch i renamed it.

thedavidmeister’s picture

thedavidmeister commented
Issue summary: View changes
Status: Needs review » Needs work

Are ugly fieldsets still an issue in ie11?

I know we all like to bash IE, but it's come a long way in the last 4 years. In light of that, I feel we should target the ie versions a bit more directly, like an ie8.css rather than ie.css.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.