It may be desired to review several specific directory. Either provide an array of directories, or possibly regex?

CommentFileSizeAuthor
#3 746730-review-array.patch6.99 KBboombatower
#1 746730-review-array.patch5.59 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 746730-review-array.patch5.59 KB

Not sure that merging arguments that are arrays will allow for proper overriding, I get the feeling it will only allow adding values unless possibly some sort of overriding based on keys or something.

This has not been tested and since it is so fundamental needs thorough testing and I need to ensure that for example on line 134 of queue.example.php:

'test.directory.review' => array(''), // Override environment default.

actually works being an array and that it doesn't just add a '' to the existing values.

boombatower’s picture

boombatower commented

Confirmed that arguments override properly.

Currently running full test.

boombatower’s picture

boombatower commented
StatusFileSize
new 746730-review-array.patch6.99 KB

Seems to work great. Added update path

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.