I can't edit my rule when running PHP 5.3:


Location https://www.example.com/admin/rules/rules/rules_19/edit/3?destination=ad...
Referrer https://www.example.com/admin/rules/rules/rules_19/edit
Message Parameter 1 to rules_forms_rules_import() expected to be a reference, value given in /var/www/pressflow/includes/module.inc on line 483.

CommentFileSizeAuthor
#8 759186-rules-ereg.patch1.31 KBklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 6.x-1.2 » 6.x-1.x-dev
Component: Rules Core » Rules Engine
Status: Active » Fixed

This has been fixed in the dev version of rules 3 weeks ago, I have no idea why it did not make it into the 1.2 release.
http://drupalcode.org/viewvc/drupal/contributions/modules/rules/rules_fo...

fizk’s picture

fizk commented

Thanks, was this one fixed as well?

Parameter 2 to rules_admin_form_edit() expected to be a reference, value given in /var/www/pressflow/includes/form.inc on line 372.

fizk’s picture

fizk commented

And this one:

Function ereg() is deprecated in /var/www/pressflow/includes/file.inc on line 911.

There are some uses of ereg/egregi in rules.....we should convert those to preg_match. Should I open a new issue?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Breaks on PHP 5.3 » PHP 5.3 problems
Status: Fixed » Active

OK, let's keep this issue active for all PHP 5.3 problems in rules.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Fixed

please reopen if any further problems occur.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

digi24’s picture

digi24 commented
Status: Closed (fixed) » Active

The deprecated ereg functions mentioned in #3 are still present.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review
StatusFileSize
new 759186-rules-ereg.patch1.31 KB

Untested patch, please test.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

It was necessary to cast the result of preg_mach to a boolean for it to work properly in the condidtion. I've done so and committed it, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.