see patch

CommentFileSizeAuthor
#3 762304-3.theme_update_version.patch5.57 KBdww
#2 drupal_762304_before.png43.04 KBtobiasb
#2 drupal_762304_after.png34.13 KBtobiasb
#2 drupal_762304.patch4.96 KBtobiasb
#1 drupal_762304.patch4.19 KBtobiasb

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new drupal_762304.patch4.19 KB
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Title: Class index in theme_update_version isn't used correct in theme_update_report and don't print empty "versions" div » theme_update_version function broken
StatusFileSize
new drupal_762304.patch4.96 KB
new drupal_762304_after.png34.13 KB
new drupal_762304_before.png43.04 KB

retitled, I hope somebody see now this no-brainer patch.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 762304-3.theme_update_version.patch5.57 KB

Yeah, it's broken alright. Re-rolled to clean this up a bit. e.g. $versionsinner => $versions_inner. Also, more consistently and carefully made use of the various class arrays.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Very nice, patch is clean and fixes a valid bug.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.