Running on a site with multiple pages of nodequeues (> 25), the sort on the admin list ends up being confusing because each page of results is sorted by the selected sort option, instead of sorting all nodequeues across the system and presenting the expected subset for a given page. This is because the pager query behind a page of results always grabs the queues by qid, then sorts them by the selected field/direction before display.

Comments

bdurbin’s picture

Title: Sort by title/max nodes on nodequeue admin list should be across all queues, not just current page » Sorting by title/max nodes on nodequeue admin list should be across all queues, not just current page
Status: Active » Needs review
StatusFileSize
new2.92 KB

This patch ensures that if enough queues exist in the system that there are multiple pages of results in the admin list, the sorting is across all of the queues, and not just for the current page of results. This works for the title and max nodes fields, but not the subqueues field, which still just sorts the current page. It still strikes me as a usability improvement since title is the default, and likely the most-used sort in the tool.

I didn't alter it, but I did notice that the sorting of the max nodes field seems intentionally reversed in the current code. I couldn't see a reason why this would be useful, but I'd be happy to enhance the patch with an explanatory comment if someone who knows better wants to clue me in.

bdurbin’s picture

StatusFileSize
new2.83 KB

Fixing an error in the previous patch.

amateescu’s picture

Status: Needs review » Needs work

The last submitted patch, 769562.nodequeue.admin-list-sort.patch, failed testing.

amateescu’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs work » Closed (duplicate)

This will be fixed in 7.x-3.x by #373174: Export and import capability for nodequeue . Closing as a duplicate in lack of a proper status..