I just noticed a strict warning in authorize.php from using the return value of one function as the argument to another that expects a reference. Simple patch, stay tuned.

CommentFileSizeAuthor
#1 777716-1.authorize-strict-warning.patch731 bytesdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 777716-1.authorize-strict-warning.patch731 bytes
dww’s picture

dww
we/he/they
commented
Issue tags: +Update manager
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Mmm, this patch no longer applies. Needs a reroll, probably.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Closed (duplicate)

Hrmph, fixed independently as a follow-up to a giant thread about E_STRICT warnings:

#348448-117: Always report E_STRICT errors

Guess it doesn't need a re-roll, since the identical patch has already been committed. ;)

atlight69’s picture

atlight69 commented
Status: Closed (duplicate) » Needs review

#1: 777716-1.authorize-strict-warning.patch queued for re-testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Closed (duplicate)