The system menu blocks look pretty ugly at this point up in the header. I'm working on a patch that will make them look like the Primary Menu links and allow for drop-down menus.

CommentFileSizeAuthor
#2 dropdowns.patch4.82 KBdeggertsen
#2 Screen shot 2010-04-21 at 6.01.34 PM.png91.13 KBdeggertsen

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Closed (duplicate)

Marking this as a duplicate of #777778: Rethink header region block handling, I don't think we need two open issues for cleaning up menu blocks in the header.

deggertsen’s picture

deggertsen commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new Screen shot 2010-04-21 at 6.01.34 PM.png91.13 KB
new dropdowns.patch4.82 KB

I've attached the patch along with a screenshot. Review and enjoy!

Jeff Burnz’s picture

Jeff Burnz commented

This wont work with IE6. There are at least two very good modules that can do this better - Nice Menus and Superfish, both of which do work with IE6 by providing Javascript support. :hover is just doesnt work in IE6 on anything but anchors.

My point being that perhaps, if we wanted this sort of thing a better solution might be to just add a new region, such as $menu_bar, and conditionally print this region if a block gets put in it, eg.

print $menu_bar ? $menu_bar : $primary_links sort of thing

Your original post is a bug report which is why it got marked as a duplicate, I didnt realise you were making a feature request, can you change it please.

deggertsen’s picture

deggertsen commented
Category: bug » feature
Status: Needs review » Needs work

I would definitely like to see this theme support this kind of menu system. I realized that what I had done doesn't support IE6 so this does need work and I like the idea of adding it as a new region. I was also thinking the header region should be aligned to the right instead of where it is now but of course that is another issue/feature request.

So I guess my question is if we should just make it so that the CSS supports nice menus and/or superfish or if there is another solution?

Jeff Burnz’s picture

Jeff Burnz commented

"should just make it so that the CSS supports nice menus and/or superfish",

That is something I would very much like to see, so many users want drop menus etc it would be great if at least one of those modules looked good right out of the box.

The other way to go about it, is if Bartik were to get into core, then I would bet that both module maintainers would accept patches that add a "Bartik" style to their modules...

deggertsen’s picture

deggertsen commented
Status: Needs work » Postponed

I'm going to postpone work on this then until we see more support for D7 from the Nice Menus and/or Superfish modules. Once we see a D7 release from them I think it will be easier to decide the final action plan.

deggertsen’s picture

deggertsen commented
Title: System Menu Blocks do not display correctly in the header » CSS support for Nice Menus and/or Superfish

Also changing the name of this feature request.

deggertsen’s picture

deggertsen commented
Issue tags: +superfish, +nice menus, +Bartik
jensimmons’s picture

jensimmons commented
Title: CSS support for Nice Menus and/or Superfish » CSS support in Bartik for Nice Menus and/or Superfish
Project: Bartik » Drupal core
Version: 7.x-1.x-dev » 8.x-dev
Component: Code » Bartik theme
Assigned: deggertsen » Unassigned
Status: Postponed » Active

Moving to Drupal project, and pushing to D8.

anne1960’s picture

anne1960 commented

Has anyone found a solution to this superfish menu in the bartik theme??

jjwhitney’s picture

jjwhitney commented

I've just created a simple subtheme for Bartik that utilizes superfish menus.

anne1960’s picture

anne1960 commented

wonderful...this one works...thanks a lot.
At least an easy install without having to mess in the code

anne1960’s picture

anne1960 commented

One additional question though. I did enable this theme. But I can't change colors for the appearance . Do I have to put this subtheme in the core Bartik file?

jjwhitney’s picture

jjwhitney commented

Hmmm... I guess the color feature doesn't get passed down to subthemes. I've fixed the problem, so try downloading again. Let me know if you have any problems. Thanks!

Jeff Burnz’s picture

Jeff Burnz commented

Hey guys, I really appreciate that you have some code you want to share and discuss, but this is the Bartik issue queue, and Drupal core at that, please take the discussion somewhere else, we use these issues to track actual issues, so what you are posting here is noise for us because its not pertaining to the issue at hand. Thanks.

anne1960’s picture

anne1960 commented

It works. thanks

Jeff Burnz’s picture

Jeff Burnz commented

After some though on this the only way I really see this happening in core is if Main menu and Secondary links become blocks (this could really happen in D8) and Nice menus and Superfish include "Bartik" styles, although we could still have a color issue so some minor support may be required there, which I would not object to.

@anne1960 - please keep it on topic.

qipengos’s picture

qipengos commented
Version: 8.x-dev » 7.16
Assigned: Unassigned » qipengos
Category: feature » support

How to apply this patch? In the wwwroot dirctory?

Version: 7.16 » 7.x-dev

Core issues are now filed against the dev versions where changes will be made. Document the specific release you are using in your issue comment. More information about choosing a version.

Status: Active » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.