If I post a reply to a thread in g.d.o and edit it several times within the span of 10 minutes, I get (and presume other subscribers to that thread get) an e-mail message for each of those edits. It would be better if there was a sanity check on sending such e-mail messages.

Steps:
1. Click a link in a g.d.o-generated e-mail "Post a reply".
2. Click login link.
3. Change http://drupal.org/user/login to https://drupal.org/user/login.
4. Enter user name and password.
5. Go down to the entry box and start typing.
6. Click Save.
7. Respond to Captcha.
8. Click Save.
9. Click edit.
Repeat steps 5-9 a few times.

Actual result: Several e-mails of my update in my e-mail in-box.
Expected result: (Assuming a send interval of Immediately) One e-mail of my update in my e-mail in-box.

Comments

silverwing’s picture

silverwing CreditAttribution: silverwing commented
Project: Drupal.org site moderators » Groups.drupal.org
Component: Groups.drupal.org » Notifications
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Make g.d.o less aggressive about sending subscribed-thread e-mails on edit update » Optionally send notifications for only the first comment edit
Project: Groups.drupal.org » Notifications
Version: » 6.x-4.x-dev
Issue tags: +gdolove
bigspring’s picture

bigspring CreditAttribution: bigspring commented

Does anyone know if there's any chance of this happening?

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
CreditAttribution: gdd commented

So I don't know much about Notifications, but it appears at first glace that a tweak to notifications_content_nodeapi() would do the trick here?

http://drupalcode.org/project/notifications.git/blob/refs/heads/6.x-4.x:...

It's a little more complicated than just nuking the 'update' $op, because you want to be able to handle the transition from unpublished to published, but otherwise it seems like it should be straightforward. I'm happy to write the patch if someone can confirm this will handle the problem. We could realllllllly use this on gdo where every edit can send out HUNDREDS of notifications.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

The ultimate solution for this for comment_notify to handle the publish/unpublished issue was to track whether the notification had been sent.

I believe the code heyrocker is pointing out would be a fix for nodes whereas the title of this issue and the problem, afaik, is with comments which is more like http://drupalcode.org/project/notifications.git/blob/refs/heads/6.x-4.x:...

I agree it would be great to fix this.

peter292’s picture

peter292 CreditAttribution: peter292 commented

Subscribe