The 'empty' state of (core) blocks is ehm, quite empty, showing only a "(empty)" piece of text.

I found this in dashboard.module:
$block->content = array('#markup' => '<div class="dashboard-block-empty">(empty)</div>');

Can we add some per-block specificity here, like "No comments/forum topics/blog posts available"?

CommentFileSizeAuthor
#7 dashboard-empty-787924-7.patch976 bytesDavid_Rothstein
#5 Screen shot 2011-01-08 at 11.25.32 PM.png49.22 KBjody lynn

Comments

yoroy’s picture

yoroy commented

Only local images are allowed.

The totally empty one for 'Active forum topics' is probably a bug worthy of its own issue?

As you can see, the 'recent content' block does have its own specific 'empty' message.

yoroy’s picture

yoroy commented
Issue tags: +Usability

tag

dmitrig01’s picture

dmitrig01 commented
Assigned: Unassigned » dmitrig01

Wow this is bad. no translation either

yoroy’s picture

yoroy commented

#504428: Roll-out 'Empty text' pattern to other admin pages. for reference

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
StatusFileSize
new Screen shot 2011-01-08 at 11.25.32 PM.png49.22 KB

Recent comments now shows an empty message.

The ones that show (empty) are blocks that outside of the dashboard would not appear at all (nothing is returned by hook_block_view when they are empty), whereas others return empty $block['contents'] and end up with blank content here.

I think nothing at all is better than (empty).

dmitrig01’s picture

dmitrig01 commented
Assigned: dmitrig01 » Unassigned
David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new dashboard-empty-787924-7.patch976 bytes

I'm not sure there is much we can do about this issue in the dashboard module itself. The dashboard does need to have some handling for blocks that are truly empty (i.e., would not otherwise display at all). To make individual blocks display but with "No X available" there needs to be issues filed against the modules that provide those blocks, I think.

The forum module block is a weird special case and does seem like its own bug. I filed an issue with a patch to fix that here: #1045390: Forum module blocks display with no content when they are empty

Attached is a patch that fixes the fact that "(empty)" wasn't translated, though. It actually was translated in one place in the code, but not in this one for some reason.... so this doesn't add any new strings. We can at least get that out of the way quickly.

Status: Needs review » Needs work

The last submitted patch, dashboard-empty-787924-7.patch, failed testing.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Needs work » Needs review

Retest.

yoroy’s picture

yoroy commented
Version: 7.x-dev » 8.x-dev

#715790: Apply 'empty state' pattern to dashboard's recent content block marked as duplicate of this

thedavidmeister’s picture

thedavidmeister commented
Issue tags: -Usability

#7: dashboard-empty-787924-7.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Usability

The last submitted patch, dashboard-empty-787924-7.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev

Dashboard module is no longer in core, see #950956: Remove Dashboard from core . Moving to 7.x for consideration.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.