In IE7, footer menu items are not inline

This is actually a pretty serious problem for all browsers, there's no accounting for a menu (ul.menu) in the footer and the styles for lists really mess with a menu, especially if its nested aka the Management menu. While the issue looks different in FF etc its still an issue that needs to be dealt with.

Embedding above screenshot for easy viewing:

Still an issue

Need to double check for the issue in #794966: In IE7, menus in the footer mistakenly have lists bullets, I'm combining these issues as they are sort of related in some ways and should be a simple fix for the both of them.

This patch fixes the alignment issues in IE7. It also fixes the list-style-image bug, and the footer font colors. There was an IE font color fallback for RGBa in style.css but it was before the RGBa and didn't get read by IE.

However, placing the color declaration after the rgba ones will override rgba for all browsers, must be some reason why the hex values are not being read by IE, IE should just ignore the rgba values and take the hex - as long as the hex come before rgba eveything should work, Bartik does this in many other places, such as the main menu tabs.

Ohh your right. Stupid mistake there. Anyway, after doing some testing, it looks like IE7 will take a fallback color for background, but not for font color. You use fallbacks for background colors elsewhere, but only one other place do you use rgba for font color. If you look in the screenshots, I've changed the page title color to rgba(0, 113, 179, 0.5) with a fallback of #0071b3. Firefox and chrome take the transparency and IE8 uses the fallback color provided. However, IE7 does not, and uses a h1 css property that colors it black instead of the fallback blue.

So after saying all that, this patch moves the css for footer font styling to ie.css which covers IE6 and IE7.
*Edit* Doesn't really move it, but adds it to ie.css to fix IE6 and IE7

Patch also includes the fixes for the bullets and misalignment.

Wow, nice to know that about IE, will test tonight when I catch a break!

I see float left, don't forget rtl ;)

tagging "Needs IE test"

tagging "Needs IE test"

Patch test fine in ie6-7. I've added rules that work for RTL.

+++ themes/bartik/css/ie-rtl.css	15 Nov 2010 01:36:33 -0000
@@ -36,3 +36,7 @@ ul.action-links li a,
+ display: inline;
+  float: none;

shouldn't this just be float:right?

+++ themes/bartik/css/ie-rtl.css	15 Nov 2010 01:36:33 -0000
@@ -36,3 +36,7 @@ ul.action-links li a,
+}
\ No newline at end of file

need a new line at the end of the file

+++ themes/bartik/css/ie.css	15 Nov 2010 01:36:33 -0000
@@ -36,3 +36,16 @@ fieldset legend {
+#footer li {
+  float: left;

should be "float:left /* LTR */ "

Powered by Dreditor.

I'm bumping this to major. It's not major for Drupal in general — but looking at the list of Bartik bugs that are left, it's one of the more major ones. The Bartik teams needs to easily see what is the highest priority for us. I say this one is in the top 5 of what's left.

@bleen18 Because [#footer li a] is already floated right in style-rtl.css and [#footer li] is floated left in style.css setting [#footer li] to float: none works and seems efficient to me. The change you're suggesting doesn't work when I test in IE6 either.

I re-tested and corrected the formatting that you pointed out. Here's the new patch.

fair enough ... its just that 99% of the time when there is float: left, the rtl version is just float:right. Ill apply and take a look at this patch a little later

#16 looks good to me. +1
Screenshot is in IE6 but IE7 is identical.

Realized that I never posted after reviewing this... ooops.

#16 looks good to me as-well ... One more for good luck and we can RTBC

Fantastic. Third review is the charm.

Ew! That's nasty. Thanks for the fix.

Committed to HEAD. Thanks!