Since phptemplate is what most themes use these days, I think it would make sense to make it the default, so we don't have to specify it in .info files. We could make it so pure PHP themes, which are the exception, need to specify engine = none or something similar.

If this is too late for 7.x, I understand. Just wanted to throw this out there in case it's not.

Comments

sun’s picture

Category: feature » task
Status: Active » Needs review
StatusFileSize
new1.01 KB

I seriously was under the impression that this is Drupal 4.7 stuff and no longer possible.

Everyone uses some engine. Almost everyone uses PHPTemplate, a minority uses Smarty. But Chameleon is most probably the only existing theme that uses no engine.

jacine’s picture

StatusFileSize
new5.87 KB

Sweet! The awesome thing about this is that it doesn't affect existing themes (in contrib). They all already have phptemplate = engine specified, and making it a default doesn't affect that at all. It's great because now you only need 2 lines in a .info file to create a theme: name and core version.

Yay for simplicity and for not exposing unnecessary complicatedness to themers for something that is done 99.9% of the time! :D

Here's an updated patch that removes the entry from themes.

sun’s picture

Status: Needs review » Reviewed & tested by the community

Nicey.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

jacine’s picture

Sweet! Thanks :)

I added docs: http://drupal.org/update/theme/6/7#engine

moshe weitzman’s picture

Nice ... To be honest, we could rip out the engine functionality in D8. It is virtually never used. Keeping around unused abstractions hurts DX.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.