The link that opens and closes the toolbar drawer doesn't show focus. This can be confusing to keyboard users, and is a failure of WCAG 2 2.4.7 AA success criteria. I think something like changing the color of the triangle to white on focus and hover would be nice.

CommentFileSizeAuthor
#11 toolbar.png558 bytesdeekayen
#4 focus_shortcuts.png38.91 KBmgifford
#3 toolbar-togglefocus.patch831 bytescasey
#3 toolbar.png619 bytescasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Everett Zufelt’s picture

Everett Zufelt CreditAttribution: Everett Zufelt commented

If a keyboard only user were on a system where the toolbar was closed, would there be any way for them to access the functionality of the toolbar without guessing about when the open control has focus?

YaxBalamAhaw’s picture

YaxBalamAhaw CreditAttribution: YaxBalamAhaw commented

As far as I can tell, the toolbar drawer is only used for "shortcuts," so keyboard-only users could access any page without using the shortcuts; but if the drawer is closed, a keyboard-only user would have to guess that the "open drawer" link had focus to open the drawer and use the shortcuts.

casey’s picture

casey CreditAttribution: casey commented
Status: Active » Needs review
FileSize
toolbar.png619 bytes
toolbar-togglefocus.patch831 bytes
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
focus_shortcuts.png38.91 KB

This modification works, but changes the display so that the arrow isn't visible when it is focused.

I've attached screenshots that demonstrates the problem I'm seeing in my sandbox. Let me know if you want to see it in action.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Shouldn't/couldn't we open the shortcuts drawer automatically on keyboard focus?

Everett Zufelt’s picture

Everett Zufelt CreditAttribution: Everett Zufelt commented

@Damien

Opening the shortcut drawer automatically on keyboard focus seems like a good idea However, if this were the case keyboard only users might end up having to tab through all shortcuts to get past the drawer every time. Providing the ability to open or close the drawer makes the most sense.

YaxBalamAhaw’s picture

YaxBalamAhaw CreditAttribution: YaxBalamAhaw commented

@mgifford I tested the patch, and it works if you replace toolbar.png with the one uploaded under the patch.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Reviewed & tested by the community

Oops. Hadn't noticed the new .png. I replaced the image file and it now is accessible using a keyboard.

Nobody else should notice a change. It is implemented here if people want to see http://drupal7.dev.openconcept.ca/

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

#3: toolbar-togglefocus.patch queued for re-testing.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

deekayen’s picture

deekayen CreditAttribution: deekayen commented
Status: Fixed » Needs review
FileSize
toolbar.png558 bytes

I shaved off some bytes with ImageOptim.

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
Status: Needs review » Reviewed & tested by the community

Saves 61 bytes. I double checked the file size using Chrome inspector and the images values using Digital Color Meter on OS X.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Thanks deekayen. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.