Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
install system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Jun 2010 at 02:22 UTC
Updated:
5 Dec 2010 at 10:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
David_Rothstein commentedMakes some sense - however, I would think the return value should be exactly consistent with module_load_include()... In other words, maybe it should just do
return module_load_include('install', $module)instead?Comment #3
oadaeh commentedThat makes sense.
My initial take on this had more code in there, but then I rethought it and pared it down, just not enough.
Comment #5
oadaeh commentedPatch created from the correct directory.
Comment #6
moshe weitzman commentedmissing doxygen for @return
Comment #7
oadaeh commentedAdded that, the missing @param, and the missing @return for the function it calls (I can remove that last one if it's stepping over the line).
Comment #8
moshe weitzman commentedlooks good. wait for green before commit.
Comment #9
David_Rothstein commentedEr, in the latest version of the patch you left out the most important part - the actual code change :)
I added that back in, plus clarified the @return docs a tiny bit to indicate that the name of the file is what's returned. I also added a blank line before the @return, to comply with coding standards.
I think it's probably still RTBC.
Comment #10
sun#9: modules-inc-828648-9.patch queued for re-testing.
Comment #11
sunAlthough badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).
Comment #12
David_Rothstein commentedI think that making a function which previously returned nothing now return something (and be consistent with other similar functions) is, although technically an API "change", not one that could ever break anyone's code under any realistic scenario.
Moving back to D7 for consideration.
Comment #13
tom_o_t commentedmodule.inc_.patch queued for re-testing.
Comment #14
webchickAgreed, this seems to just be fixing an oversight in the existing API.
Committed to HEAD.